Bug 8070 - Warnings when scanning mp3 files
: Warnings when scanning mp3 files
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Scanner
: 7.0.1
: PC Windows XP
: P5 minor with 1 vote (vote)
: 7.x
Assigned To: Andy Grundman
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-05-05 21:32 UTC by Bill Miller
Modified: 2009-07-31 10:20 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments
mp3 track, creates many warnings in log when scanning (3.86 MB, audio/mpeg)
2008-07-17 06:17 UTC, Markus Schiegl
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Bill Miller 2008-05-05 21:32:03 UTC
Just installed 7.0.1 - 19397. Running XP MCE sp2. Did a clear and rescan. Got following errors in log:

[08-05-05 18:44:36.5431] MP3::Info::_grab_int_16 (2125) Warning: substr outside of string at C:\PROGRA~1\SQUEEZ~1\server\lib/MP3/Info.pm line 2125, <$fh> line 1.
[08-05-05 18:44:36.5457] MP3::Info::_parse_v2tag (721) Warning: Use of uninitialized value in substr at C:\PROGRA~1\SQUEEZ~1\server\lib/MP3/Info.pm line 721, <$fh> line 1.
[08-05-05 18:44:36.5479] MP3::Info::_parse_v2tag (721) Warning: Use of uninitialized value in substr at C:\PROGRA~1\SQUEEZ~1\server\lib/MP3/Info.pm line 721, <$fh> line 1.
[08-05-05 19:11:00.6023] Slim::Utils::SoundCheck::commentTagTodB (44) Warning: Argument "1.#J" isn't numeric in addition (+) at C:/PROGRA~1/SQUEEZ~1/server/Slim/Utils/SoundCheck.pm line 44.
[08-05-05 19:18:35.6441] MPEG::Audio::Frame::broken (618) Warning: Use of uninitialized value in right bitshift (>>) at C:\PROGRA~1\SQUEEZ~1\server\lib/MPEG/Audio/Frame.pm line 618, <$mpeg> chunk 9.

[08-05-05 19:18:35.6467] MPEG::Audio::Frame::broken (619) Warning: Use of uninitialized value in right bitshift (>>) at C:\PROGRA~1\SQUEEZ~1\server\lib/MPEG/Audio/Frame.pm line 619, <$mpeg> chunk 9.

[08-05-05 19:18:35.6489] MPEG::Audio::Frame::broken (620) Warning: Use of uninitialized value in right bitshift (>>) at C:\PROGRA~1\SQUEEZ~1\server\lib/MPEG/Audio/Frame.pm line 620, <$mpeg> chunk 9.

[08-05-05 19:18:35.6585] MPEG::Audio::Frame::broken (621) Warning: Use of uninitialized value in right bitshift (>>) at C:\PROGRA~1\SQUEEZ~1\server\lib/MPEG/Audio/Frame.pm line 621, <$mpeg> chunk 9.

[08-05-05 19:20:44.3370] MPEG::Audio::Frame::broken (618) Warning: Use of uninitialized value in right bitshift (>>) at C:\PROGRA~1\SQUEEZ~1\server\lib/MPEG/Audio/Frame.pm line 618, <$mpeg> chunk 9.

[08-05-05 19:20:44.3396] MPEG::Audio::Frame::broken (619) Warning: Use of uninitialized value in right bitshift (>>) at C:\PROGRA~1\SQUEEZ~1\server\lib/MPEG/Audio/Frame.pm line 619, <$mpeg> chunk 9.

[08-05-05 19:20:44.3418] MPEG::Audio::Frame::broken (620) Warning: Use of uninitialized value in right bitshift (>>) at C:\PROGRA~1\SQUEEZ~1\server\lib/MPEG/Audio/Frame.pm line 620, <$mpeg> chunk 9.

[08-05-05 19:20:44.3439] MPEG::Audio::Frame::broken (621) Warning: Use of uninitialized value in right bitshift (>>) at C:\PROGRA~1\SQUEEZ~1\server\lib/MPEG/Audio/Frame.pm line 621, <$mpeg> chunk 9.

[08-05-05 19:24:02.1871] MPEG::Audio::Frame::broken (618) Warning: Use of uninitialized value in right bitshift (>>) at C:\PROGRA~1\SQUEEZ~1\server\lib/MPEG/Audio/Frame.pm line 618, <$mpeg> chunk 3.

[08-05-05 19:24:02.1894] MPEG::Audio::Frame::broken (619) Warning: Use of uninitialized value in right bitshift (>>) at C:\PROGRA~1\SQUEEZ~1\server\lib/MPEG/Audio/Frame.pm line 619, <$mpeg> chunk 3.

[08-05-05 19:24:02.1915] MPEG::Audio::Frame::broken (620) Warning: Use of uninitialized value in right bitshift (>>) at C:\PROGRA~1\SQUEEZ~1\server\lib/MPEG/Audio/Frame.pm line 620, <$mpeg> chunk 3.

[08-05-05 19:24:02.2100] MPEG::Audio::Frame::broken (621) Warning: Use of uninitialized value in right bitshift (>>) at C:\PROGRA~1\SQUEEZ~1\server\lib/MPEG/Audio/Frame.pm line 621, <$mpeg> chunk 3.

[08-05-05 19:43:08.0779] MPEG::Audio::Frame::broken (618) Warning: Use of uninitialized value in right bitshift (>>) at C:\PROGRA~1\SQUEEZ~1\server\lib/MPEG/Audio/Frame.pm line 618, <$mpeg> chunk 9.

[08-05-05 19:43:08.0801] MPEG::Audio::Frame::broken (619) Warning: Use of uninitialized value in right bitshift (>>) at C:\PROGRA~1\SQUEEZ~1\server\lib/MPEG/Audio/Frame.pm line 619, <$mpeg> chunk 9.

[08-05-05 19:43:08.0825] MPEG::Audio::Frame::broken (620) Warning: Use of uninitialized value in right bitshift (>>) at C:\PROGRA~1\SQUEEZ~1\server\lib/MPEG/Audio/Frame.pm line 620, <$mpeg> chunk 9.

[08-05-05 19:43:08.0852] MPEG::Audio::Frame::broken (621) Warning: Use of uninitialized value in right bitshift (>>) at C:\PROGRA~1\SQUEEZ~1\server\lib/MPEG/Audio/Frame.pm line 621, <$mpeg> chunk 9.

[08-05-05 20:19:39.6315] MP3::Info::_grab_int_16 (2125) Warning: substr outside of string at C:\PROGRA~1\SQUEEZ~1\server\lib/MP3/Info.pm line 2125, <$fh> line 1.
[08-05-05 20:19:39.6338] MP3::Info::_parse_v2tag (721) Warning: Use of uninitialized value in substr at C:\PROGRA~1\SQUEEZ~1\server\lib/MP3/Info.pm line 721, <$fh> line 1.
[08-05-05 20:19:39.6359] MP3::Info::_parse_v2tag (721) Warning: Use of uninitialized value in substr at C:\PROGRA~1\SQUEEZ~1\server\lib/MP3/Info.pm line 721, <$fh> line 1.
[08-05-05 20:19:39.6988] MP3::Info::_grab_int_16 (2125) Warning: substr outside of string at C:\PROGRA~1\SQUEEZ~1\server\lib/MP3/Info.pm line 2125, <$fh> line 1.
[08-05-05 20:19:39.7019] MP3::Info::_parse_v2tag (721) Warning: Use of uninitialized value in substr at C:\PROGRA~1\SQUEEZ~1\server\lib/MP3/Info.pm line 721, <$fh> line 1.
[08-05-05 20:19:39.7040] MP3::Info::_parse_v2tag (721) Warning: Use of uninitialized value in substr at C:\PROGRA~1\SQUEEZ~1\server\lib/MP3/Info.pm line 721, <$fh> line 1.
[08-05-05 20:19:39.8714] MP3::Info::_grab_int_16 (2125) Warning: substr outside of string at C:\PROGRA~1\SQUEEZ~1\server\lib/MP3/Info.pm line 2125, <$fh> line 1.
[08-05-05 20:19:39.8736] MP3::Info::_parse_v2tag (721) Warning: Use of uninitialized value in substr at C:\PROGRA~1\SQUEEZ~1\server\lib/MP3/Info.pm line 721, <$fh> line 1.
[08-05-05 20:19:39.8757] MP3::Info::_parse_v2tag (721) Warning: Use of uninitialized value in substr at C:\PROGRA~1\SQUEEZ~1\server\lib/MP3/Info.pm line 721, <$fh> line 1.
[08-05-05 20:19:40.3548] MP3::Info::_grab_int_16 (2125) Warning: substr outside of string at C:\PROGRA~1\SQUEEZ~1\server\lib/MP3/Info.pm line 2125, <$fh> line 1.
[08-05-05 20:19:40.3573] MP3::Info::_parse_v2tag (721) Warning: Use of uninitialized value in substr at C:\PROGRA~1\SQUEEZ~1\server\lib/MP3/Info.pm line 721, <$fh> line 1.
[08-05-05 20:19:40.3594] MP3::Info::_parse_v2tag (721) Warning: Use of uninitialized value in substr at C:\PROGRA~1\SQUEEZ~1\server\lib/MP3/Info.pm line 721, <$fh> line 1.
Comment 1 KDF 2008-05-06 09:08:17 UTC
Try setting scan.scanner to DEBUG in server settings->logging.  Check the log again for these messages, and the new debug should let you know which files are to blame.  Please attach one of those files.  Also, it appears to involve the Replay Gain tags.  Which tagger did you use to apply ReplayGain/Soundcheck values?

Are the files in question still playable?
Comment 2 James Richardson 2008-05-12 09:26:36 UTC
Ping Bill for a response to KDF's suggestions

Comment 3 Chris Owens 2008-06-13 09:35:32 UTC
Bill would it be possible to upload a file which causes these kinds of warnings and attach it to the bug?  Thanks!
Comment 4 Markus Schiegl 2008-07-17 06:11:29 UTC
I get similar logs on my installation (linux, SC7.1) and was able to narrow it down to 3 problem mp3 tracks. I'll attach one, which is responsible for 64 lines of log, like:

[08-07-17 13:58:14.9253] MPEG::Audio::Frame::broken (618) Warning: Use of uninitialized value in right bitshift (>>) at /opt/SqueezeCenter_svn/7.1/trunk/server/lib/MPEG/Audio/Frame.pm line 618, <$mpeg> chunk 294.

[08-07-17 13:58:14.9257] MPEG::Audio::Frame::broken (619) Warning: Use of uninitialized value in right bitshift (>>) at /opt/SqueezeCenter_svn/7.1/trunk/server/lib/MPEG/Audio/Frame.pm line 619, <$mpeg> chunk 294.

[08-07-17 13:58:14.9260] MPEG::Audio::Frame::broken (620) Warning: Use of uninitialized value in right bitshift (>>) at /opt/SqueezeCenter_svn/7.1/trunk/server/lib/MPEG/Audio/Frame.pm line 620, <$mpeg> chunk 294.

[08-07-17 13:58:14.9263] MPEG::Audio::Frame::broken (621) Warning: Use of uninitialized value in right bitshift (>>) at /opt/SqueezeCenter_svn/7.1/trunk/server/lib/MPEG/Audio/Frame.pm line 621, <$mpeg> chunk 294.

[08-07-17 13:58:14.9265] MPEG::Audio::Frame::broken (616) Warning: substr outside of string at /opt/SqueezeCenter_svn/7.1/trunk/server/lib/MPEG/Audio/Frame.pm line 616, <$mpeg> chunk 294.

My files are still playable (and properly recognized by SC) so i'm not completely sure if this is the same issue.

Log-Level for scanner.* is set to "error"...

kind regards,
Markus
Comment 5 Markus Schiegl 2008-07-17 06:17:18 UTC
Created attachment 3614 [details]
mp3 track, creates many warnings in log when scanning
Comment 6 Markus Schiegl 2008-07-18 05:35:20 UTC
I've found a way to "repair" those mp3 files which were responsible for those log messages on my system. The tools i used are called "MP3 repacker" and it's GUI "WinMP3Packer".

A little bit more detailed: http://forums.slimdevices.com/showthread.php?p=320916#post320916

kind regards,
Markus
Comment 7 Andy Grundman 2008-08-01 07:06:35 UTC
7.2 change 22293 fixes a few warnings in MPEG::Audio::Frame when reading mp3 files with bad frames such as this one.  Repairing them is also a good thing to do, as it will improve the scanning speed.
Comment 8 James Richardson 2008-10-10 11:43:23 UTC
Verified fixed in

SqueezeCenter 7.2.1-23472
Comment 9 Mike Walsh 2008-10-10 14:36:01 UTC
Andy,

how do you know which mp3s to fix?  will SC still log warnings for problematic ones?
Comment 10 Andy Grundman 2008-10-10 15:30:02 UTC
Well, you don't know which ones.  Maybe the scanner should log every track before it scans it so you can tell.
Comment 11 Mike Walsh 2008-10-10 15:39:34 UTC
i truly don't know if thats a good idea or not, or if that would make the scan take longer, etc...  but perhaps it could be a debug option or something...?

i didn't know mp3s could be damaged or need "repair" or that that would make scans take longer.  i def would appreciate some way to ID them.

is there a 3rd party app that can do that?  if so that would mean SC wouldn't have to do it every scan, if it saves scan time not to.
Comment 12 Andy Grundman 2008-10-10 15:42:37 UTC
There is another enhancement for an 'event log', I expect it would be a place where you could see warnings about possibly corrupt files in your library.
Comment 13 Mike Walsh 2008-10-12 18:31:48 UTC
i can't find that event bug.  do you know where it is?

and now that u fixed this bug, my Q is does SC still log broken mp3s anywhere?
Comment 14 James Richardson 2008-12-15 12:33:48 UTC
This bug has been fixed in the 7.3.0 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Comment 15 Chris Owens 2009-07-31 10:20:40 UTC
Reduce number of active targets for SC