Bugzilla – Bug 8044
Need brightness option under Settings > SN
Last modified: 2009-09-08 09:14:33 UTC
There should be a way of choosing the brightness level from Settings in the player ui. Without a brightness button on the remote, the only alternative is the web interface. Of course, this all depends on how effective auto dimming is and whether that's the default.
Huh, never noticed that it was missing. It would be incredibly tedious to use, but it should be there somewhere. Setting the Auto (light sensing) mode or setting to Manual and a single fixed brightness setting would probably be the only practical use.
so, should the setting be there in all player menus, or only available from a boom player?
I don't see why we would limit it to boom.
initial patch at change 19450. Todo: - still needs to handle a scalable number of brightness options - only handles ONE option beyond the maxBrightness index. Could we potentially have more? - potentially remove the autobrightness option.
Looks good. Couple of minor tweaks... KDF: can you remove the Automatic Display Brightness option and rename the three choices to: Power On Brightness Power Off Brightness Idle Brightness Thx!
so, are we removing the automatic pref for all, or just boom?
strings done at change 19632
The automatic pref is just confusing, let's remove it. Thx!
change 19641 removes all uses of the pref, corrects strings and settings. strings will need new translations, so I've cleaned out the non-EN. reopen if there are any issues. complaints may be directed to mr. blackketter :)
This change seems to have broken the Auto Display third-party plugin, which attempts to change the brightness level of power off mode overnight. The plugin seems to change the brightness, but then SC resets it back to the configured brightness level. I don't think it's particularly clear what the difference is between: Power On Brightness Idle Brightness If you switch from power off to power on, that's idle mode is it not?
see also bug 7922, which is REALLY what causes the auto dim to no longer work. See also comments in Bug 8237. The plugin should really be adjusted to work around what is the correct thing for the server to be doing, pending any changes such as those mentioned in bug 1850. Power On Brightness vs Idle Brightness (idle state is post-screensaver timeout). Pressing POWER will trigger a reset of the IR timer, thus enters Power on brightness. See Slim::Buttons::ScreenSaver::wakeup(). Only if the button is 'brightness' or mapped to the "dead" function will the brightness remain in "idle" setting, or in any other case where perhaps a plugin is resettings the LastIRTime
>see also bug 7922, which is REALLY what causes the auto dim to no longer work. bug 7922, comment #4 indicates that it will continually check against the current pref and adjust accordingly, but ONLY if the setting for automatic adjustment is checked. bug 8044 has subsequently removed the auto adjustment code, but it still automatically continually checks and changes brightness levels. Is it really right that the server should need to continually be checking and if necessary changing the brightness level? I would have thought that only a single one-off change would be necessary when a brightness change is committed (eg. when changing the setting via WebUI). For a plugin to change the brightness level using it's own rules, it appears that the plugin will now have to overwrite the relevant SC brightness value? >Power On Brightness vs Idle Brightness I think I understand now. "Power on" means when someone is actively using the box (i.e. has pressed a key on the standard IR remote, and also presumably any special keys on the box, such as Transporter front panel keys). Idle is when the power is on, but no key has been pressed (effectively when the "Screensaver when playing" or "Screensaver when stopped" is invoked). I think the information pop-up for the "Power on brightness" setting needs updating (it still mentions the auto brightness functionality), and perhaps additional information could be added to "Power off brightness" and "Idle brightness" settings to clarify what they are for.
removal of the automatic brightness pref means it is always automatic. Removing the pref means that the option to shut it off, manual operation only, is no longer available. Thus, checking is required, because it is designed to match the PREF. Given that the pref can be changed from multiple locations, it needs to check periodically for ir state changes and pref change. Yes, we could create onChange callbacks for the pref change, but then it would have to know the state of the ir timer (requiring a new ir callback to update ir state) and power. All possible, but also works as written. As always, patches are welcome, but should be attached to a new report.
Brightness Settings do not function. going to the setting I get a bounce when attempting to go right on the 3 chooses Settings > Display > Brightness > : 1) While On 2) While Off 3) Idle Brightness Using FW 14 Connected to SN Connected to SC 7.1-20714 the feature functions properly
reassigning, since there is nothing I can do about SN stuff. I can only guess that there was a missed merge (perhaps missing maxBrightness or the BrightnessMap from the Boom player class.
Heh the problem is the button code is calling into the web code! All the web code is not loaded on SN.
getBrightnessOptions is probably better in the base Display class then.
Created attachment 3465 [details] move getBrightnessOptions to display class
patch merged to branch at change 20981. Hope that works better.
SN has a Settings -> Display -> Brightness menu.
Verified to be working on boom.squeezenetwork.com today.
This bug has been fixed in the latest release of SqueezeNetwork! If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.