Bug 7943 - New volume mode doesn't dismiss on other button push
: New volume mode doesn't dismiss on other button push
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Player UI
: 7.2
: Macintosh Other
: -- normal (vote)
: 7.x
Assigned To: Adrian Smith
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-04-22 13:47 UTC by Blackketter Dean
Modified: 2009-07-31 10:19 UTC (History)
0 users

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Blackketter Dean 2008-04-22 13:47:19 UTC
With the new volume mode code, the volume display doesn't dismiss if you hit an unrelated button.

For example, press volume up, then immediately press the left arrow.  the volume indicator will stay up, and will remain up if you continue to press the left arrow button.
Comment 1 Adrian Smith 2008-04-23 14:06:18 UTC
I won't get chance to look at this for a few days, but recording kdf's comment from campfire:

it's ugly, but you could trap incoming ir (a la Shadowplay) and trigger the exit from Volume for any codes not directly related to volume. Or, we could add some sort of callback flag that says "function wasn't found for this mode" so the mode could then look for that to exit and let common handle the button

alternative is to list the common buttons in Default.map for this mode and set them to trigger exit.
Comment 2 Adrian Smith 2008-05-02 13:03:15 UTC
I think this is half fixed - if you press left/right it cancels.  If you press play/pause/rew/fwd it performs the action and then returns to the volume display.  Is this ok (otherwise we need some more options to add to the button mode used)
Comment 3 Blackketter Dean 2008-05-02 13:24:20 UTC
I think it should dismiss the volume display, like it would if it were a showbriefly.  no need to ever bring it back.

Comment 4 Adrian Smith 2008-05-02 13:35:19 UTC
Do we need to action the button press as well - so we need to create an "exit and passback" action for the button handler - we have one or the other at present.
Comment 5 Blackketter Dean 2008-05-02 13:43:22 UTC
I think it should feel like a showbriefly, so yes, the button press gets passed on.
Comment 6 Adrian Smith 2008-05-03 05:20:11 UTC
I believe 19377 works as we want - will exit the mode and passback the key press to previous mode.
Comment 7 James Richardson 2008-10-10 10:22:20 UTC
Verified fixed in

SqueezeCenter 7.2.1-23472
Controller 7.2 r3070
Receiver r48
SB2/3 r113
Transporter r63
Boom r33
Comment 8 James Richardson 2008-12-15 12:33:45 UTC
This bug has been fixed in the 7.3.0 release version of SqueezeCenter!

Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Comment 9 Chris Owens 2009-07-31 10:19:48 UTC
Reduce number of active targets for SC