Bug 7907 – Artwork in FLAC not showing if picture type is not 3 (Cover)

Bug 7907 - Artwork in FLAC not showing if picture type is not 3 (Cover)

Summary:

Artwork in FLAC not showing if picture type is not 3 (Cover)

Status:	CLOSED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Artwork
Version:	7.0.1
Platform:	PC Ubuntu Linux

Importance:	-- normal (vote)
Target Milestone:	7.x
Assigned To:	Andy Grundman

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2008-04-20 02:21 UTC by Hendrik van Antwerpen
Modified:	2009-07-31 10:19 UTC (History)
CC List:	1 user (show)

See Also:
Category:	---

Attachments
Example flac file with embedded image (2.35 MB, application/octet-stream) 2008-04-20 02:23 UTC, Hendrik van Antwerpen	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Hendrik van Antwerpen 2008-04-20 02:21:25 UTC

The artwork in my FLAC files is not showing up.
Example file attached.

Comment 1 Hendrik van Antwerpen 2008-04-20 02:23:23 UTC

Created attachment 3266 [details]
Example flac file with embedded image

Comment 2 Andy Grundman 2008-04-20 10:39:41 UTC

The problem is we currently only look for picture type 3 (Cover) and the image in this file is type 0 (Other).  I'll update the code to look for other image types.

Comment 3 Andy Grundman 2008-04-20 10:45:15 UTC

Fixed in 7.0.1 change 18962.

Comment 4 Hendrik van Antwerpen 2008-04-20 13:38:21 UTC

This bug was the result of a mistake I made (shame shame). Since this is then not a realworld example, you might consider reverting this change and stick to the standard. Otherwise people might have the wrong pictures showing up for files having non-cover images included.

Personally I'd stick to the standard and revert the cahnge, but at least you know where the bug came from.

Comment 5 Andy Grundman 2008-04-20 13:47:16 UTC

Well I still think the patch is fine, it looks for the first picture in this order:

    * 3 - Cover (front)
    * 4 - Cover (back)
    * 0 - Other
    * 5 - Leaflet page
    * 6 - Media (e.g. label side of CD)
    * 7 - Lead artist/lead performer/soloist
    * 8 - Artist/performer
    * 9 - Conductor
    * 10 - Band/Orchestra
    * 11 - Composer
    * 12 - Lyricist/text writer
    * 13 - Recording Location
    * 14 - During recording
    * 15 - During performance
    * 16 - Movie/video screen capture
    * 17 - A bright coloured fish
    * 18 - Illustration
    * 19 - Band/artist logotype
    * 20 - Publisher/Studio logotype

Comment 6 Hendrik van Antwerpen 2008-04-20 13:49:10 UTC

Ok, I didn't look to the patch, I think that will work OK.

Comment 7 Ross Levine 2008-05-02 16:21:40 UTC

Verified working 7.0.1 - 19325

Comment 8 James Richardson 2008-05-15 12:30:53 UTC

This bug has recently been fixed in the latest release of SqueezeCenter 7.0.1

Please try that version, if you still see the error, then reopen this bug.

To download this version, please navigate to: http://www.slimdevices.com/su_downloads.html

Comment 9 Chris Owens 2009-07-31 10:19:39 UTC

Reduce number of active targets for SC