Bug 789 - itemsPerPage=-1 == BOOM
: itemsPerPage=-1 == BOOM
Status: RESOLVED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Web Interface
: 5.x or older
: PC RedHat Linux
: P2 minor (vote)
: ---
Assigned To: Blackketter Dean
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-01-18 01:30 UTC by Jools Searle
Modified: 2008-12-18 11:52 UTC (History)
0 users

See Also:
Category: ---


Attachments
test playlist_items before join (442 bytes, patch)
2005-01-19 01:21 UTC, KDF
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jools Searle 2005-01-18 01:30:05 UTC
I've discovered that whan you set "itemsPerPage=-1" when retrieving
status.xml, the server crashes (well mine does anyway - SlimServer Version
5.3.1 running on RH8.0).  I only tried it as I have written a Konfabulator
Widget that displays the currently pleying track info along with the
relevant coverart.  As my widget doesn't care about the playlist, I tried
setting "itemsPerPage=0" which had the effect of listing the full playlist
again.  I then thought I'd try setting it to -1 (hoping for a "while
loopcount < itemsPerPage" type logic to kick in) - but BOOOM (or rather
"SILENCE" from my speakers) as the slimserver process took a nose-dive.
It's not really a problem, but someone should check it out as it should be a
case of some simple input verification to either cope with negative numbers
(to mean "don't list any"), or to ignore the invalid request.  It's an
easily repeatable issue.
Comment 1 KDF 2005-01-19 01:21:33 UTC
Created attachment 257 [details]
test playlist_items before join

This checks that we have playlist_items before joining the array and causing a
crash.	end result should be status output only with no playlist items
Comment 2 KDF 2005-01-20 18:27:54 UTC
merged to 5.4.1 Jan 20, 2005
Comment 3 Chris Owens 2006-06-16 14:41:57 UTC
There are 536 bugs in the database with targets of '---' that were fixed prior to new year 2006.  I am setting them to targets of 6.2.1 to keep them from showing up in my queries.
Comment 4 Chris Owens 2008-12-18 11:52:49 UTC
Routine bug db maintenance; removing old versions which cause confusion.  I apologize for the inconvenience.