Bugzilla – Bug 7866
Leave volume bar up longer
Last modified: 2009-09-08 09:26:54 UTC
I think the volume bar disappears just a _little_ bit too quickly. Leaving it up a bit longer would facilitate using the knob for volume adjustment. I find myself sometimes hesitating while adjusting the volume with the knob and then the bar disappears and I have to press the volume rocker again to get it back.
This is trivial to change, but by default would impact the time it is up for IR mode as well (on all players). Should we make it longer for all or does it need to be boom specific?
Can we have the timeout a bit longer just if you use scroll to adjust volume?
'scroll' meaning the knob? We could do longer if we enter the volume mode via the front panel rather than via the remote? Would this be ok? [just the knob means bigger changes as we check the timeout at a point in the code which doesn't know if it is the knob or volup/down which is being updated]
I meant the knob(s) and up/down arrows. (i.e. Not the volume buttons.)
Thats more changes... Need to look at checking the timeout somewhere which knows what input method is being used.
If this isn't straightforward, or if it will affect other things, I think I'd wait for additional comments from others before doing antyhing. I can certainly live with it like it is.
(In reply to comment #3) > We could do longer if we enter the volume mode via the front panel rather than > via the remote? Would this be ok? Since this has been targeted, I'd like to comment that I think this is all that's needed. When using the remote, if the bar is lost you don't lose control of volume - you just press the same button again without missing a beat. It doesn't seemt very likely to me that anyone is going to press a volume control on the remote and then use the knob. If they do, then they just get the shorter timeout. This should also fully address any issues someone may have with not moving quickly enough from the front panel volume control to the knob.
Triode, the mapping should currently be using volume_front for the buttons, so you can simply check the $buttonarg for "front" and that should work
sorry, triode. That is how it should work, but having checked on it something has been done incorrectly along the way and ir will also call volume_front. That should be the place to do the detection, were it working correctly.
I'll look at (may need to be later this week though) - as you say should be trivial. I'm wary of changing too much as we also have a request from Dean to make the volume the default operation of the knob for the now playing mode.
on idea was to get rid of "volume_forward" in the map, changing it to "volume". Then, create a special case in Hardware::IR::processFrontPanel so that when idCode == 'volume', at line 768 call: processCode($client, $irCode."_front", $irTime); Then in the volume sub of Buttons::Common, check for $buttonarg == $forward and set the timeout there accordingly. As a long term change, it's not nice but if you want simple and maybe short term, there is one idea.
change 20427 should leave the volume display up for 3 seconds if initiated via the front panel, but only 1 second if from the remote control. Let me know what you think...
Fixed then. If anyone doesn't like Triode's changes please re-open!
Verified functioning properly with r19 & 7.2-22118
This bug has been fixed in the latest release of SqueezeCenter! Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already. If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.