Bug 786 - menu_browse_artist key binding messes up menu structure
: menu_browse_artist key binding messes up menu structure
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Player UI
: 5.x or older
: All All
: P2 normal (vote)
: Future
Assigned To: Blackketter Dean
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-01-16 07:52 UTC by Marc Sherman
Modified: 2008-12-18 11:55 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Sherman 2005-01-16 07:52:59 UTC
I've remapped the brightness key in Default.map to Browse Artist if pressed, or
Browse Genres if held:

# MSS 2005jan14: Remap Brightness to Browse Artist/Genre
# brightness                            = brightness_toggle
brightness.single                       = menu_browse_artist
brightness.hold                         = menu_browse_genre

However, it doesn't behave quite the way I expected to.  If I'm in Now Playing
mode, and press the brightness key, it takes me to Browse Artists as I expected.
 However, if I then press the Left key, it goes back to Now Playing.  If then
hit Right, I'm back in Browse Artists. It's as though Browse Artists has been
added below Now Playing in the menu structure.  This persists until I change the
playlist, at which point Now Playing becomes itself again.

Looking at the code (.../Slim/Buttons/Common.pm), it looks like the line:
   Slim::Buttons::Common::setMode($client, 'home');
before the cascading if block should root the Browse Artists/Genres mode off the
root of the menu, but it doesn't seem to be having that effect.
Comment 1 KDF 2005-05-05 20:44:35 UTC
I've tried this out with 6.1 nightly May 05, 2005.  This includes a few fixes to
the menu jumping code and it appears to have fixed this in some fashion.  Using
the remote in this way will then jump to Browse Artist, but it will jump as if
this is a top level item.  Thus, if you press left at this point, you will be at
the top level menu.  Pressing right will drop into the proper menu item, instead
of going back to browse artist.

Please confirm if this is now functioning as you were expecting, re-open if an
issue still remains
Comment 2 James Richardson 2008-12-15 13:06:06 UTC
This bug appears to have been fixed in the latest release!

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.

Make sure to include the version number of the software you are seeing the error with.
Comment 3 Chris Owens 2008-12-18 11:55:17 UTC
Routine bug db maintenance; removing old versions which cause confusion.  I apologize for the inconvenience.