Bug 785 – Radio stream url entry on web page does not pass client-id to protocol handler

Bug 785 - Radio stream url entry on web page does not pass client-id to protocol handler

Summary:

Radio stream url entry on web page does not pass client-id to protocol handler

Status:	RESOLVED INVALID

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Streaming To SlimServer
Version:	6.0.0
Platform:	All Windows XP

Importance:	P2 normal (vote)
Target Milestone:	---
Assigned To:	Blackketter Dean

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2005-01-15 17:40 UTC by Adrian Smith
Modified:	2005-02-05 07:24 UTC (History)
CC List:	0 users

See Also:
Category:	---

Attachments
Possible fix - patch to Slim/Utils/Scan.pm (544 bytes, patch) 2005-01-15 17:42 UTC, Adrian Smith	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Adrian Smith 2005-01-15 17:40:11 UTC

If a radio stream url is entered via the web page, a protocol handler can be 
called without specifying the client id (and hence can't pick the right 
conversion commands).  This occurs if the url is a direct audio url rather 
than a playlist url.  This appears to be because with 6.0, Scan.pm is 
responsible for calling openRemoteStream on any url added on the web page.  If 
this does not match a song type, it is assumed to be a playlist and 
openRemoteStream is called without $client.
This impacts AlienBBC, but I suspect it will also impact mms:// streams.

I don't understand why this is different on 6.0 from previously?  I will 
attach a possible fix, but I don't understand any side effects of this.

Comment 1 Adrian Smith 2005-01-15 17:42:38 UTC

Created attachment 252 [details]
Possible fix - patch to Slim/Utils/Scan.pm

Comment 2 Adrian Smith 2005-02-05 07:24:45 UTC

No longer a problem in later 6.0 builds.