Bug 7789 – Can't delete playlists in default and Fishbone skins

Bug 7789 - Can't delete playlists in default and Fishbone skins

Summary:

Can't delete playlists in default and Fishbone skins

Status:	CLOSED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Playlists
Version:	7.0.1
Platform:	PC Other

Importance:	-- normal (vote)
Target Milestone:	7.x
Assigned To:	KDF

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2008-04-10 09:07 UTC by Jeff Roesner
Modified:	2011-03-16 04:34 UTC (History)
CC List:	3 users (show)

See Also:
Category:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jeff Roesner 2008-04-10 09:07:43 UTC

I installed Nightly 18632 and found that I can't delete playlists from the UI.  Clicking delete brings up the confirmation prompt but there is no confirmation checkbox to check to complete the deletion.  This happens with both IE7 and FF3 beta 5.

Comment 1 KDF 2008-04-10 10:01:10 UTC

fixed in 7.0/trunk at change 18650

Comment 2 Jeff Roesner 2008-04-11 05:44:33 UTC

Still present in build 18669.

Version info:

SqueezeCenter Version: 7.0.1 - 18669 @ Fri Apr 11 00:27:06 PDT 2008 - solaris - EN - utf8
Server IP address: 192.168.1.3
Perl Version: 5.8.8 i86pc-solaris
MySQL Version: 5.0.51a

Comment 3 KDF 2008-04-11 07:49:52 UTC

argh.  well, the fix is valid, but something else has broken at the same time.  The warning flags appear to be gone so the delete confirm checkbox no longer appears anywhere.  With viewCVS down, I'm having a hard time finding where this was changed :(

Comment 4 KDF 2008-04-11 08:00:43 UTC

seems to have been 18482 where the lines:
$params->{'DELETE_WARNING'} = 1;
and
$params->{'RENAME_WARNING'} = 1;

were removed.  These are used to flag the inclusion of the checkbox.  Michael, are these something we can bring back in for supporting legacy skins?

Comment 5 Michael Herger 2008-04-11 08:21:06 UTC

Sure! Will take a look at it. Sorry.

Comment 6 KDF 2008-04-11 11:53:21 UTC

actually, I know a way we can work with what's there.  I can compare with the warning token.

Comment 7 KDF 2008-04-11 12:22:48 UTC

change 18702 should have it restored.   Tested with ff3b5, but don't have IE7.  Please reopen if there are problems.

Comment 8 James Richardson 2008-05-15 12:30:34 UTC

This bug has recently been fixed in the latest release of SqueezeCenter 7.0.1

Please try that version, if you still see the error, then reopen this bug.

To download this version, please navigate to: http://www.slimdevices.com/su_downloads.html

Comment 9 Chris Owens 2009-07-31 10:19:26 UTC

Reduce number of active targets for SC