Bug 778 – Names of plugins in web interface uses output of getDisplayName directly

Bug 778 - Names of plugins in web interface uses output of getDisplayName directly

Summary:

Names of plugins in web interface uses output of getDisplayName directly

Status:	RESOLVED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Web Interface
Version:	6.0.0
Platform:	All All

Importance:	P2 minor (vote)
Target Milestone:	---
Assigned To:	KDF

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2005-01-10 14:20 UTC by Jules Taplin
Modified:	2008-09-15 14:37 UTC (History)
CC List:	0 users

See Also:
Category:	---

Attachments
stringify plugin additional links (2.18 KB, patch) 2005-01-11 00:13 UTC, KDF	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jules Taplin 2005-01-10 14:20:20 UTC

Changes between v5.4 and v6 changed the handling of 'getDisplayName' for
plugins. The new behavious simply passes back the token, not the localisation.

However... if a plugin registers a web interface... it's entry on the 'home'
page of the web interface displays it's token, not the localisation of it's token.

Comment 1 KDF 2005-01-10 18:20:23 UTC

do you mean the server home page? or the home page of the plugin's custom
webpages?

Comment 2 Jules Taplin 2005-01-11 00:04:49 UTC

Server homepage.

It looks like this, currently:

<Settings>
* <Settings Items>
<Plugins>
* ALIENBBC_PLUGIN
<Help>
* <Help Items>

Before I had to change the getDisplayName() function to return the token 
rather than the expanded form, that would have read something like: 'AlienBBC 
v<whatever>', instead of ALIENBBC_PLUGIN.

Comment 3 KDF 2005-01-11 00:13:15 UTC

Created attachment 249 [details]
stringify plugin additional links

This patches the home page for Fishbone, Default and Lite.
other skins may still need this, but I'll take care of them too once this one
is confirmed.

Comment 4 KDF 2005-01-12 00:24:53 UTC

fixed in 6.0 for EN, Default, Fishbone, and NBMU.  These are all that have their
own home.html for displaying plugin links.

Comment 5 Chris Owens 2006-06-16 14:41:56 UTC

There are 536 bugs in the database with targets of '---' that were fixed prior to new year 2006.  I am setting them to targets of 6.2.1 to keep them from showing up in my queries.