Bug 7675 - new scan is not launched when needed if only iTunes or MusicIP, but no music path is defined
: new scan is not launched when needed if only iTunes or MusicIP, but no music ...
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Misc
: 7.0.1
: Macintosh Other
: P4 minor (vote)
: 7.x
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-03-31 01:16 UTC by Michael Herger
Modified: 2009-07-31 10:18 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
remove "visit http://localhost:9000 to configure... blahblah" (932 bytes, patch)
2008-04-07 05:47 UTC, Michael Herger
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Herger 2008-03-31 01:16:48 UTC
 
Comment 1 Michael Herger 2008-03-31 03:15:36 UTC
Kevin - it seems as if the importers were not added during startup. Do you have an idea why this is?
Comment 2 KDF 2008-03-31 12:03:06 UTC
well, without looking it all up...could this be due to recent changes in how itunes/musicip default on new installs?  Wasn't there a recent rant about iTunes defaulting on that resulted in a change?  Perhaps the change was too reactive and needs to be done with a conditional such that if the music folder hasn't been selected and either of these are found then it is enabled and active by default?
Comment 3 KDF 2008-03-31 12:04:36 UTC
unfortunately, the ONLY working setup I have right now is at work thus only able to test anything when I'm "bored" at the day job (something went up in flames friday so I far from bored today).  Things at home are on running lights only until I get time to relocate and get set up in the new house.
Comment 4 Michael Herger 2008-04-01 00:04:59 UTC
Do you know from the top of your hat at which point addImporter is actually called? It looks as if these plugins were initialized ok and everything, but addImporter is only called either very late in the startup process or only when a scan is launched for the first time or something. importers() doesn't return anything when SC is almost up and checking for a data source.
Comment 5 Michael Herger 2008-04-01 07:13:51 UTC
did you mean bug 5609 which might have changed this?
Comment 6 KDF 2008-04-01 13:16:09 UTC
That's not what I was thinking of, but maybe related.  It may have not actually been a bug, but just another forum rant in around the same time as the bug you mention.

Originally addImporter was supposed to be called during initPlugin so that the importer would be registered.  Whether or not it is in use would be up to the 'use' key which would be set for iTunes by default, and cleared for mip by default.  This stuff has been changed over and over, not always by me so I can't remember what the flow is now without some digging.

Comment 7 Michael Herger 2008-04-02 03:30:03 UTC
I wouldn't bother about the log any more (rather remove that message), but the case is a bit more serious if a restart should result in a rescan due to a schema change or other. Changing title accordingly.
Comment 8 Michael Herger 2008-04-07 05:47:40 UTC
Created attachment 3203 [details]
remove "visit http://localhost:9000 to configure... blahblah"

Dean, Andy - any objection against this simple patch? We've been adding a lot of complexity for a message most users will never see. And this logic is once again broken. We could spend some more time trying to fix it, at the risk of breaking something else. Or we get rid of the message and simplify life: Why not just let the scanner decide whether an importer is available or not and remove that message? 

Only users running SC manually from a shell/command window would see this message. Any user using one of our installers doesn't see it anyway (unless he goes digging in the logs).
Comment 9 Michael Herger 2008-04-09 01:49:23 UTC
patch applied in change 18585
Comment 10 James Richardson 2008-05-09 10:57:49 UTC
Verified fixed in 7.0.1 - 19325 
Comment 11 James Richardson 2008-05-15 12:30:00 UTC
This bug has recently been fixed in the latest release of SqueezeCenter 7.0.1

Please try that version, if you still see the error, then reopen this bug.

To download this version, please navigate to: http://www.slimdevices.com/su_downloads.html
Comment 12 Chris Owens 2009-07-31 10:18:53 UTC
Reduce number of active targets for SC