Bug 7651 – Always use 'icon-id' not 'icon' for SqueezeCenter content

Bug 7651 - Always use 'icon-id' not 'icon' for SqueezeCenter content

Summary:

Always use 'icon-id' not 'icon' for SqueezeCenter content

Status:	CLOSED FIXED

Product:	SB Controller
Classification:	Unclassified
Component:	Browser
Version:	unspecified
Platform:	PC Windows XP

Importance:	P3 normal (vote)
Target Milestone:	7.0.1
Assigned To:	Ben Klaas

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2008-03-28 04:39 UTC by Richard Titmuss
Modified:	2008-05-08 10:19 UTC (History)
CC List:	1 user (show)

See Also:
Category:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Richard Titmuss 2008-03-28 04:39:26 UTC

See checkin r2152. The only example I've found where the wrong icon type is used is the favorites icon.

Ben please fix SC to always use icon-id for it's content. The semantics should be with 'icon-id' jive is allowed to add a 56x56_o to the icon, with 'icon' it must leave the url alone. After SC is correct please remove the extra condition in SlimBrowser where marked with XXXX.

Thanks.

Comment 1 Richard Titmuss 2008-03-28 05:19:50 UTC

The code in NowPlaying applet needs a similar cleanup.

Comment 2 Richard Titmuss 2008-03-28 05:22:50 UTC

And the no artwork in now playing must be served by SC and not using the local content. the corner transparency is not handled correctly. I assume SC is incorrectly sending an icon-id for the now playing track, when it has no artwork?

Comment 3 Ben Klaas 2008-03-28 09:24:11 UTC

AFAICT, the only spot with 'icon' instead of 'icon-id' was several spots in Queries.pm. Plugins thankfully are already using icon-id.

SC 7.0 trunk change 18107 has these changes.

Will have jive-side changes checked in shortly.

Comment 4 Ben Klaas 2008-03-28 09:41:29 UTC

squeezeplay trunk r2155 has the remainder of my changes.

on review of NowPlaying, there's some code in there for server:isSqueezeNetwork() that I'm not comfortable hacking out. Regardless, nothing there now that's a problem wrt this bug.

moving to RESOLVED

Comment 5 James Richardson 2008-05-08 10:19:01 UTC

(In reply to comment #4)
> squeezeplay trunk r2155 has the remainder of my changes.
> 
> on review of NowPlaying, there's some code in there for
> server:isSqueezeNetwork() that I'm not comfortable hacking out. Regardless,
> nothing there now that's a problem wrt this bug.
> 
> moving to RESOLVED
> 

Closing