Bug 7649 - MusicIP should return info about missing player instead of empty playlistq
: MusicIP should return info about missing player instead of empty playlistq
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: MusicIP
: 7.0
: PC Windows XP
: P3 normal (vote)
: 7.x
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-03-27 23:31 UTC by Michael Herger
Modified: 2009-07-31 10:18 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Herger 2008-03-27 23:31:40 UTC
The MIP web interface returns "Empty" when mixing without a player connected. This should either be the playlist (because it doesn't hurt) or at least a message that you need to connect a player to play the mix.
Comment 1 Michael Herger 2008-03-28 01:41:09 UTC
Kevin - is there anything wrong with the following patch? This would allow browsing the mix, as browsing anything is possible without a player. And afaict it doesn't break anything.

Index: D:/eclipse/trunk/server/Slim/Plugin/MusicMagic/Plugin.pm
===================================================================
--- D:/eclipse/trunk/server/Slim/Plugin/MusicMagic/Plugin.pm	(revision 18103)
+++ D:/eclipse/trunk/server/Slim/Plugin/MusicMagic/Plugin.pm	(working copy)
@@ -869,7 +869,7 @@
 		# We'll be using this to play the entire mix using 
 		# playlist (add|play|load|insert)tracks listref=musicmagic_mix
 		$client->modeParam('musicmagic_mix',$mix);
-	} else {
+	} elsif (!defined $mix || ref $mix ne "ARRAY") {
 		$mix = [];
 	}
 
Comment 2 KDF 2008-03-28 07:39:18 UTC
seems to me that if you need to set $mix=[] when $mix is undefined, that the real need here is to initialise $mix.  Do we not have a 'my $mix = [];' earlier in the code?
Comment 3 Michael Herger 2008-03-28 07:48:25 UTC
getMix() does "return undef" in some places. Thus we can't rely on it being initialized.
Comment 4 KDF 2008-03-28 08:00:18 UTC
right.  makes sense then.
Comment 5 Michael Herger 2008-03-28 08:08:05 UTC
change 18108 - allow mixes, even if no player is available, instead of simply returning an empty playlist. Thanks for the feedback, kdf!
Comment 6 James Richardson 2008-05-15 12:25:29 UTC
This bug has recently been fixed in the latest release of SqueezeCenter 7.0.1

Please try that version, if you still see the error, then reopen this bug.

To download this version, please navigate to: http://www.slimdevices.com/su_downloads.html
Comment 7 Chris Owens 2009-07-31 10:18:45 UTC
Reduce number of active targets for SC