Bugzilla – Bug 7649
MusicIP should return info about missing player instead of empty playlistq
Last modified: 2009-07-31 10:18:45 UTC
The MIP web interface returns "Empty" when mixing without a player connected. This should either be the playlist (because it doesn't hurt) or at least a message that you need to connect a player to play the mix.
Kevin - is there anything wrong with the following patch? This would allow browsing the mix, as browsing anything is possible without a player. And afaict it doesn't break anything. Index: D:/eclipse/trunk/server/Slim/Plugin/MusicMagic/Plugin.pm =================================================================== --- D:/eclipse/trunk/server/Slim/Plugin/MusicMagic/Plugin.pm (revision 18103) +++ D:/eclipse/trunk/server/Slim/Plugin/MusicMagic/Plugin.pm (working copy) @@ -869,7 +869,7 @@ # We'll be using this to play the entire mix using # playlist (add|play|load|insert)tracks listref=musicmagic_mix $client->modeParam('musicmagic_mix',$mix); - } else { + } elsif (!defined $mix || ref $mix ne "ARRAY") { $mix = []; }
seems to me that if you need to set $mix=[] when $mix is undefined, that the real need here is to initialise $mix. Do we not have a 'my $mix = [];' earlier in the code?
getMix() does "return undef" in some places. Thus we can't rely on it being initialized.
right. makes sense then.
change 18108 - allow mixes, even if no player is available, instead of simply returning an empty playlist. Thanks for the feedback, kdf!
This bug has recently been fixed in the latest release of SqueezeCenter 7.0.1 Please try that version, if you still see the error, then reopen this bug. To download this version, please navigate to: http://www.slimdevices.com/su_downloads.html
Reduce number of active targets for SC