Bugzilla – Bug 7586
FLAC.pm should be a little stricter parsing track titles in _getCDDBTags
Last modified: 2009-07-31 10:18:26 UTC
FLAC.pm, in a TTITLE tag, simply looks for a slash before deciding that the title represents an "Artist / Title" combination. This hits tracks with actual slashes in the title though, producing a bogus artist and title. I'd suggest something a little stricter, like at least looking for " / " in the TTITLE, and/or checking that the album's artist is "Various".
An issue which won't make it for 7.1. To be reviewed for a future release.
I thought guess tags only used folder and file names, not tag data. You can't have a forward slash in a file name, can you?
Jim, this doesn't appear to be guessTags. I believe this is addressing CDDB or Cuesheet tag parsing in Formats::Flac where the title is given as Artist/Title. I'm not a user of this type of formatting, so I can't speak to how often the format would strictly adhere to " / " vs "/". I don't think we can guarantee whitespace in there. Specifying it as a requirement is an option, but then so is specifying a limitation on the use of "/" when using this type of formatting.
How are these tags added to the files? Can you give me a CDDB ID example where our code breaks?
Not going to make it for 7.1. That example data would still be welcome!
Created attachment 3479 [details] Patch to tweak artist and title recognition in whole-CD flacs
Basically, any case where there's a slash not surrounded by spaces. See http://www.freedb.org/en/faq.3.html#22 , number 6: 6. When submitting a sampler or compilation, you should include the track-artist in the track-name, using the syntax "artist / track-title" and set the CD-artist to "Various" Almost all the time, the cddb entries I've seen have interpreted this as requiring spaces around the slash. I've attached a patch that fixed it to my satisfaction. I've had to repair a few of the cddb entries locally to work with this, but at least this patch makes it possible, meets the "standard", and required the least rework. As for an example: pretty much any of the cddb entries for Aphex Twin's _Richard D. James Album_. "Girl/Boy Song" will break with the current system, and there's no aesthetically tolerable way to fix it without switching away from cddb format in the flacs (which I do also plan to do one of these days, but I can write scripts easily, others aren't so lucky), or changing FLAC.pm to not recognize that as an Artist/Title. Another alternative would be to look for something like "Various" as the CD artist. I actually don't prefer this, because I have some CDs with both their own artist and individual artists per track. But the cddb FAQ says the artist in this case should be "Various", so I can deal with it. Hope this helps.
Thanks, patch applied as 7.2 change 22152.
Verified fixed in SqueezeCenter 7.2.1-23472
This bug has been fixed in the 7.3.0 release version of SqueezeCenter! Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already. If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Reduce number of active targets for SC