Bugzilla – Bug 7585
DRM track in Playlists causes scanner to quit scan
Last modified: 2009-07-31 10:18:25 UTC
It's taken me so long to work this out (grumble) If a playlist created in WMP contains even a single DRM-protected track then Squeezecenter 7.0 scan crashes out and the scan of the playlist folder ceases and is not completed. This is really annoying. I understand SqueezeCentre can't play DRM tracks, but it needs to be fixed so that it simply skips over them. It's not right that it casues the whole scan to crash. please can this be fixed. As it stands I if I create any playlist in WMP that contains a DRM track, ALL my playlists can didsappear from my squeezecenter..
is there a log entry showing what crashed?
Here is what the scanner.log says [08-03-23 20:43:44.7286] main::main (210) Error: Failed when running main scan: [Can't call method "remote" on an undefined value at /<C:\PROGRA~1\SQUEEZ~1\server\scanner.exe>Slim/Utils/Scanner.pm line 882. ] [08-03-23 20:43:44.7289] main::main (211) Error: Skipping post-process & Not updating lastRescanTime!
Steven: Can you do the following please 1) delete your current scanner.log file 2) turn the following log options to DEBUG; (scan) - All Scan Logging (scan.import) - File & Playlist Metadata Import Logging (scan.scanner) - Music & Playlist Folder Scanning 3) perform a "only rescan playlist" 4) tell me which WMA tracks in which playlist are DRM protected 5) attach the scanner.log file to this bug
Created attachment 3134 [details] 3 scan logs Very strange error, I was able to reproduce it once I had a .wpl & .m3u playlist in the same folder, each with a DRM track in them. When I had ONLY 1 of each type of PL, the error did not happen.
Sure, I will do this for you when I get home from work this evening. And at the same time and I'll see if this wierd m3u and wpl scenario applies. (I don't actually think so - but I'll check)
KDF have you seen this behavior before or know of a fix
Below should easily fix the current crasher. I suspect that given a drm file in the playlist, we may still have other issues after this as far as making sure we're doing the right thing. I'm not sure whether the file should remain shown as part of the playlist but not playable, or be automatically removed, at least in the db-stored version. Unfortunately, I don't have a test set for this, nor do I really have a lot of time these days to try it all out (buying/selling a house over the last couple weeks and next few weeks I'll be moving). The way the market is around here, it's all a bit chaotic. The patch can be applied to 7.0/trunk, and I guess we can see what happens from there. Index: C:/slim/server/Slim/Utils/Scanner.pm =================================================================== --- C:/slim/server/Slim/Utils/Scanner.pm (revision 18071) +++ C:/slim/server/Slim/Utils/Scanner.pm (working copy) @@ -901,7 +901,7 @@ # Copy playlist title to all items if they are remote URLs and do not already have a title for my $track ( @playlistTracks ) { - if ( $track->remote ) { + if ( defined $track && $track->remote ) { my $curTitle = $track->title; if ( !$curTitle || Slim::Music::Info::isURL($curTitle) ) { $track->title( $playlist->title );
Created attachment 3139 [details] scanner log
Created attachment 3140 [details] playlist with DRM track
I have followed instructions and re-created the bug easily. Notes - the playlists folder contains only .WPL files - yearning.wpl contains a DRM-protected track "02 Philosphers Stone (2007 Remastered).wma" - when scanner processes this playlist it crashes - removing the DRM track stops it crashing - scanner also crashes it it encounters a missing file (also irritating but less so) ATTACHMENTS scanner.log yearning.wpl
KDF: Thanks for the quick response, good luck on the house thing :) Steve: Thank you for the extra effort and log Andy: Can you have a look at KDF's code, re-assign the bug to QA when it's in 7.0.1 and we can test it out.
Patch applied to 7.0 trunk as change 18131.
Verified to be fixed in 7.0.1 - 19597.
This bug has recently been fixed in the latest release of SqueezeCenter 7.0.1 Please try that version, if you still see the error, then reopen this bug. To download this version, please navigate to: http://www.slimdevices.com/su_downloads.html
Reduce number of active targets for SC