Bug 756 - setup links broken when running on port 80
: setup links broken when running on port 80
Status: RESOLVED DUPLICATE of bug 758
Product: Logitech Media Server
Classification: Unclassified
Component: Web Interface
: 5.x or older
: PC All
: P2 normal (vote)
: ---
Assigned To: KDF
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2004-12-30 15:32 UTC by michael
Modified: 2008-12-18 11:53 UTC (History)
0 users

See Also:
Category: ---


Attachments
patch to allow setup links to work when running on port 80 (1005 bytes, patch)
2004-12-30 15:38 UTC, michael
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description michael 2004-12-30 15:32:27 UTC
Setup links (server settings, player settings, etc) don't work when slimserver
is running on port 80. Attempting to follow one of these links results in a 403
page.

It appears that preventing cross-site scripting attacks means insuring that the
referrer in the http request is the same host slimserver is running on. However
the actualy comparison looks at hostname:port and when running on port 80, the
browser will compress this to just hostname, and the comparison fails.
Comment 1 michael 2004-12-30 15:38:24 UTC
Created attachment 234 [details]
patch to allow setup links to work when running on port 80

this was diffed against BRANCH_5_4_x but works with trunk just as well.
Comment 2 Blackketter Dean 2005-01-03 16:58:43 UTC
Good find.  KDF: Can you help out here?
Comment 3 KDF 2005-01-03 19:04:54 UTC
The patch looks fine, however, bug758 addresses a concern for greater security
yet allowing bookmarked pages that this referrer test will not allow.  

Perhaps this could be committed to 5.4.1, leaving bug758 to be merged into 6.0.
 The referrer test might then be completely removed from 6.0
Comment 4 KDF 2005-01-07 01:53:45 UTC
This problem is going to be handled by removing the referrer check and use the
security settings given in bug758, or some variation

*** This bug has been marked as a duplicate of 758 ***
Comment 5 Chris Owens 2008-12-18 11:53:20 UTC
Routine bug db maintenance; removing old versions which cause confusion.  I apologize for the inconvenience.