Bug 7554 – Inconsistent use of reportsTrackStart and player type

Bug 7554 - Inconsistent use of reportsTrackStart and player type

Summary:

Inconsistent use of reportsTrackStart and player type

Status:	CLOSED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Audio
Version:	7.0
Platform:	PC Other

Importance:	-- normal (vote)
Target Milestone:	7.x
Assigned To:	Alan Young

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2008-03-19 10:37 UTC by Alan Young
Modified:	2009-09-08 09:30 UTC (History)
CC List:	0 users

See Also:
Category:	---

Attachments
Patch (440 bytes, patch) 2008-03-19 10:37 UTC, Alan Young	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alan Young 2008-03-19 10:37:04 UTC

Source.pm uses $client->reportsTrackStart() as a proxy for $client->isa("Slim::Player::Squeezebox2") or other capability tests in a number of cases. This really needs replacing with better capability management in general but the short-term problem is that the tests are used inconsistently. The attached patch resolves this and makes squeezeslave perform more reliably.

Comment 1 Alan Young 2008-03-19 10:37:46 UTC

Created attachment 3118 [details]
Patch

Comment 2 Blackketter Dean 2008-03-19 12:13:35 UTC

Looks ok to me, but in general, I think we should move to capability flags as our list of players becomes more complex (keep in mind SBR, SBC, TR, SB3, SB1, SLIMP3, SoftSqueeze, SqueezePlay, SqueezeSlave and more soon...) and the simple object hierarchy doesn't really express the capabilities clearly.

Comment 3 Alan Young 2008-03-19 14:18:41 UTC

Agreed.

Comment 4 Alan Young 2008-03-19 14:24:43 UTC

Change 17937

Comment 5 James Richardson 2008-05-08 15:51:57 UTC

(In reply to comment #4)
> Change 17937
> 

Closing bug

Comment 6 Chris Owens 2009-07-31 10:18:17 UTC

Reduce number of active targets for SC