Bugzilla – Bug 7478
playlistTrack not mixable
Last modified: 2009-07-31 10:17:54 UTC
Steps to reproduce: Music Library->Playlists->choose playlist Press and hold PLAY on a playlist track fails to mix. Log shows: Slim::Plugin::MusicMagic::Plugin::getMix (661) Error: No valid type specified for mix This is because the type in this mode is given by $levels[$level]. This is 'playlistTrack' when browsing playlists, so this is invalid. Fix should be to correct this in the mixerfunction. Reproduceable with current svn 7.0.1
proposed patch (alternative is to check for playlistTrack in mixerfunction AND getMix, changing to 'track' only at the last second for the call to the mixer API): Index: C:/slim/server/Slim/Plugin/MusicMagic/Plugin.pm =================================================================== --- C:/slim/server/Slim/Plugin/MusicMagic/Plugin.pm (revision 17841) +++ C:/slim/server/Slim/Plugin/MusicMagic/Plugin.pm (working copy) @@ -500,9 +501,13 @@ $mixSeed = $currentItem->name; } + + # Bug: 7478: special handling for playlist tracks. + if ($levels[$level] eq 'playlistTrack') { + $mixSeed = $currentItem->path; + $mix = getMix($client, $mixSeed, 'track'); + } elsif ($currentItem && ($paramref->{'mood'} || $currentItem->musicmagic_mixable)) { - if ($currentItem && ($paramref->{'mood'} || $currentItem->musicmagic_mixable)) { - # For the moment, skip straight to InstantMix mode. (See VarietyCombo) $mix = getMix($client, $mixSeed, $levels[$level]); }
change 18084 - thanks again, Kevin!
(In reply to comment #2) > change 18084 > Closing bug.
Reduce number of active targets for SC