Bug 7435 - jive.version incorrect in trunk updates
: jive.version incorrect in trunk updates
Status: CLOSED FIXED
Product: SB Controller
Classification: Unclassified
Component: Development package
: unspecified
: Macintosh Other
: P1 normal (vote)
: 7.0.1
Assigned To: Richard Titmuss
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-03-07 00:38 UTC by KDF
Modified: 2008-05-02 11:23 UTC (History)
0 users

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description KDF 2008-03-07 00:38:13 UTC
the jive.version file in the trunk updates does not have the version line, so the .bin file has incorrect naming and isn't being downloaded for updates.

jive.version in http://update.squeezenetwork.com/update/firmware/7.0.1/ looks like:

root@padbuild #2 Thu Mar 6 01:27:26 PST 2008

while 7.0 looks like:
7.0 r2090
root@padbuild #57 Wed Mar 5 02:02:06 PST 2008
Comment 1 sbjaerum 2008-03-07 01:53:27 UTC
Going backwards one step in the build process, I see the following differences at the end of the build log files

http://update.slimdevices.com/downloads/nightly/latest/7.0/buildlog.jive.txt :
  adding: root.cramfs (deflated 1%)
7.0 r2090
root@padbuild #57 Wed Mar 5 02:02:06 PST 2008

http://update.slimdevices.com/downloads/nightly/latest/trunk/buildlog.jive.txt :
  adding: root.cramfs (deflated 1%)
root@padbuild #3 Fri Mar 7 01:25:09 PST 2008

The generation of the version information seems to be missing in the trunk build process.

Comment 2 KDF 2008-03-07 01:58:50 UTC
the mkversion script didnt' get the name changes.  I think I have a fix, due momentarily
Comment 3 KDF 2008-03-07 02:01:45 UTC
r2096 should do it.  too late for today's build. leaving open until we can see it in action.
Comment 4 sbjaerum 2008-03-08 04:27:38 UTC
May be

cat ../../squeezeplay/src/squeezeplay/src/version.h | cut -sd\" -f 2

instead of

cat ../../../squeezeplay/src/squeezeplay/src/version.h | cut -sd\" -f 2
Comment 5 KDF 2008-03-08 10:26:50 UTC
I thought that too, but then it wouldn't work on my checkout, so couldn't see the point of checking in something that doesn't work on a copy of the repo.
Comment 6 KDF 2008-03-08 10:35:52 UTC
tried it for r2098.  I guess we can see what the build machine does with it.  it may be a case of me having to do a fresh checkout yet again.
Comment 7 Richard Titmuss 2008-03-12 05:12:17 UTC
Looks good at r2100. Thanks for spotting this guys.
Comment 8 James Richardson 2008-05-02 11:23:54 UTC
Closing bug, please reopen if you still see the issue