Bug 7426 - Power-on-resume does not work for Internet radio
: Power-on-resume does not work for Internet radio
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Audio
: 7.0
: PC Other
: -- normal (vote)
: 7.x
Assigned To: Alan Young
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-03-05 22:52 UTC by Alan Young
Modified: 2009-07-31 10:17 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Young 2008-03-05 22:52:17 UTC
The "Pause at power off / Resume at power on" selection for Settings / Players / <player> / Audio / Power On Resume does not work as expected.

On power-off, if the current song is a remote URL, then it does a Stop instead of a Pause. This seems perfectly reasonable.

On power-on, if the current song is a remote URL, then it does not Play. This does not seem right. When an SB is being used for Internet radio then one would expect that "turning the radio back on" would have it start playing again.

Not all remote URLs are radio stations (live streams) and so, in some cases, power-on-Play would restart the previously-playing track instead of resuming it. If this is a general problem, then the user can select an alternate value for the Power On Resume preference. It is not possible, in general, to tell if a remote URL represents a live stream or not.

The relevant code fragment is at the end of Slim::Player::Player::power():

	if ($resumeOn =~ /Play/ && Slim::Player::Playlist::song($client) &&
		!Slim::Music::Info::isRemoteURL(Slim::Player::Playlist::url($client))) {
		# play if current playlist item is not a remote url
		$client->execute(["play"]);
	}
Comment 1 Adrian Smith 2008-03-07 15:41:04 UTC
I tend to agree with this (I suspect its my code..)  The critical thing is to make sure that stop is executed when the player is powered off to drop the internet stream.
Comment 2 Blackketter Dean 2008-03-14 07:14:17 UTC
I agree. Resume on power on should work if the user was playing a radio station and powered off.  

Powering on should restart, I think.

You know, like a radio.


Comment 3 Alan Young 2008-03-14 08:34:43 UTC
Dean, do you want to set a target for this?
Comment 4 Alan Young 2008-03-20 01:24:12 UTC
Change 17944
Comment 5 James Richardson 2008-05-08 15:01:07 UTC
Verified fixed in 7.0.1 - 19325
Comment 6 James Richardson 2008-05-15 12:28:57 UTC
This bug has recently been fixed in the latest release of SqueezeCenter 7.0.1

Please try that version, if you still see the error, then reopen this bug.

To download this version, please navigate to: http://www.slimdevices.com/su_downloads.html
Comment 7 Chris Owens 2009-07-31 10:17:49 UTC
Reduce number of active targets for SC