Bugzilla – Bug 7371
Playing an album leaves player playlist incorrect
Last modified: 2009-09-08 09:12:49 UTC
To reproduce: 1) Player is playing an album 2) Switch off player 3) Using Jive, navigate to a different album and press Play 4) Go to Now Playing 5) Press center button to go to playlist 5) Screen shows old playlist, not current one 6) SC7 web display is however updated with the correct playlist Jive r2081 SqueezeCenter Version: 7.0 - 17725 - Windows XP - EN - cp1252
probably related to bug 7370
almost definitely related. The playlist html is a heavy process, therefore it is often skipped for any cases where it is reasonable to expect the playlist to remain unchanged. "off" is one of those cases. Whatever play command is being used by the jive cli call is probably not doing the right thing with the player power state. I suspect that you'll find that player power is being handled by the button mode and by the web ui, leaving a cli-only implementation hole.
this has the same root cause as bug 7370, which is already fixed in trunk. But in this case, for some reason the setTitle method for step.window (the current playlist window) is not getting set. step.window:setTitle(_string(modeTokens[token])) debug shows that setTitle method is getting the proper string to change the window title to, but it isn't changing when invoked in the manner as described in this bug. needs further investigating...
removing priorities from all 7.0.1 target bugs for re-prioritizing
this is a P1 for 7.0.1
looks like the title is getting set twice. some debug for my own notetaking... -- after hitting 'play' on an album when player is off 144013:69675 INFO (SlimBrowserApplet.lua:809) - _menuSink() 144013:69682 INFO (SlimBrowserApplet.lua:809) - _menuSink() 144013:70264 INFO (NetworkThread.lua:248) - NOTIFY playerPlaylistSize: Player {Office SB3}, 12 144013:70264 INFO (SlimBrowserApplet.lua:1902) - SlimBrowser.notify_playerPlaylistSize 144013:70264 WARN (Player.lua:141) - _setPlayerPower0 144013:70264 WARN (Player.lua:755) - Office SB3 144013:70264 INFO (NetworkThread.lua:248) - NOTIFY playerModeChange: Player {Office SB3}, play 144013:70264 INFO (SlimBrowserApplet.lua:1968) - SlimBrowser.notify_playerModeChange 144013:70264 INFO (SlimBrowserApplet.lua:1976) - play|0 144013:70264 INFO (SlimBrowserApplet.lua:1985) - Now Playing 144013:70264 WARN (Window.lua:470) - setTitle() 144013:70264 WARN (Window.lua:472) - self.title says yes: Now Playing 144013:70264 INFO (NetworkThread.lua:248) - NOTIFY playerTrackChange: Player {Office SB3}, 7491 144013:70265 WARN (NowPlayingApplet.lua:210) - PLAYER TRACK NOTIFICATION RECEIVED 144013:70265 INFO (NetworkThread.lua:248) - NOTIFY playerPlaylistChange: Player {Office SB3} -- when entering current playlist window 144017:74476 WARN (NowPlayingApplet.lua:567) - player=Player {Office SB3} status=table: 0x1655aa30 144018:75187 WARN (Window.lua:470) - setTitle() 144018:75187 WARN (Window.lua:472) - self.title says yes: Off so it looks like the title is set correctly until the playlist window is actually entered, when it gets set incorrectly. nice feature ;) narrowing down on it at least...
bah, I feel like I've been punked. This ended up being a one line fix. I was operating under the impression this was an SC issue on notifying SBC about player power state, when it was on the Jive side the whole time. <smacks forehead> fixed in trunk r2167
Verified fixed in 7.0.1 - 19325 r2409 - r23
This bug has recently been fixed in the latest release of SqueezeCenter 7.0.1 Please try that version, if you still see the error, then reopen this bug. To download this version, please navigate to: http://www.slimdevices.com/su_downloads.html