Bug 7295 - SBC fw 2009 + SBR fw 18 + SN setup fails
: SBC fw 2009 + SBR fw 18 + SN setup fails
Status: CLOSED FIXED
Product: SB Controller
Classification: Unclassified
Component: Setup
: unspecified
: PC Windows XP
: P2 blocker (vote)
: 7.0
Assigned To: Richard Titmuss
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-02-23 10:58 UTC by Chris Owens
Modified: 2009-09-08 09:14 UTC (History)
3 users (show)

See Also:
Category: ---


Attachments
Jive log file of the process (143.99 KB, text/plain)
2008-02-23 11:10 UTC, Chris Owens
Details
Patch (3.12 KB, patch)
2008-02-24 04:54 UTC, Richard Titmuss
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Owens 2008-02-23 10:58:36 UTC
Note this is not for 7.0 per se, but for the next run of Jive MP

These are my notes about the relative states of Ray and Jive as I went through the process.

Jive: Choose Language			Ray: Red slow flash
Jive: Welcome	
Jive: Wireless Region
Jive: Spinny: finding networks
Wireless Networks screen, selected network
Wireless Encryption, selected encryption type
Wireless Key, entered key
Set Up Reciever, selected correct receiver
Spinny: Connecting to wlanroutername
Choose Music Source			Ray: steady blue
selected SqueezeNetwork as my music source
got PIN
added pin to the SN web ui
Jive shows spinny: Connecting to SN	Ray: Blinking bright white
					Ray appears done, rebooting
					Ray yellow, green, blue, dim white
Jive still showing spinny
Jive shows: Problem Connecting, Try again or Skip this step
Comment 1 Andy Grundman 2008-02-23 11:02:51 UTC
Richard, I think the problem is this:

Setup sits in t_waitSlimserver waiting for playerNew.  It gets one, but the player needs a firmware upgrade.  The next event that is sent is playerNeedsUpgrade because the player never actually is removed from the database, so another playerNew is not sent when the player reconnects.  Also, maybe the setup squeezebox code needs to show the firmware update spinny here, but that's not a 7.0 thing. 

This patch may help, but it's untested.

--- jive/share/applets/SetupSqueezebox/SetupSqueezeboxApplet.lua	(revision 29842)
+++ jive/share/applets/SetupSqueezebox/SetupSqueezeboxApplet.lua	(local)
@@ -1310,6 +1310,15 @@
 	notify_playerNew(self, player)
 end
 
+-- called when player goes from needing an upgrade to not needing an upgrade,
+-- i.e. when it comes back from firmware update.  If the player record was never
+-- removed while it was upgrading, this is the only message we get when it
+-- comes back.
+function notify_playerNeedsUpgrade(self, player, needsUpgrade)
+	if not needsUpgrade then
+		notify_playerNew(self, player)
+	end
+end
 
 -- make sure Jive is reconnected to it's network when setup fails.
 function t_connectJiveOnFailure(self)
Comment 2 Chris Owens 2008-02-23 11:10:00 UTC
Created attachment 2982 [details]
Jive log file of the process

Note the 'Connecting to SqueezeNetwork' spinny goes for about 90 seconds
Comment 3 Chris Owens 2008-02-23 11:39:47 UTC
Also note, for whatever reason this works fine on a local SC
Comment 4 Andy Grundman 2008-02-23 12:21:01 UTC
While trying to test my above patch, I seemed to not be able to get Ray to update properly.  It would go into a 4-purple upgrade error cycle for a while before actually getting upgraded to 22.
Comment 5 Richard Titmuss 2008-02-24 04:54:32 UTC
Created attachment 2986 [details]
Patch

This patch:
- increases the extended timeout during firmware upgrade to 3 minutes.
- uses the playerNeedsUpgrade notification to detect when the upgrade is complete.
- forces waitSlimserver state when waiting for a squeezebox to upgrade.
- fixes the playerNew notification, so that the player.needsUpgrade state is correct.
Comment 6 Richard Titmuss 2008-02-24 08:54:25 UTC
Fixed in r2011.
Comment 7 Blackketter Dean 2008-02-24 09:26:53 UTC
QA to verify.
Comment 8 Chris Owens 2008-02-24 11:14:18 UTC
I'm now seeing the 4 purple flashes consistently after Ray connects to SN, but it reboots relatively quickly and then successfully updates its FW.  I'm marking this verified.
Comment 9 Blackketter Dean 2008-02-24 11:54:20 UTC
Cc'ing Felix on this as there are purple flashes here.
Comment 10 Chris Owens 2008-02-24 13:11:58 UTC
I opened a new bug for that issue: bug 7315
Comment 11 James Richardson 2008-05-15 13:05:14 UTC
This bug has recently been fixed in the latest release of SqueezeCenter 7.0.1

Please try that version, if you still see the error, then reopen this bug.

To download this version, please navigate to: http://www.slimdevices.com/su_downloads.html