Bugzilla – Bug 7281
Language Selector in first run wizard - Hebrew can not be selected
Last modified: 2009-09-08 09:25:22 UTC
When going through the Setup Wizard for SC7 for the first time on OS X 10.x, I noticed a language selector drop down. When browsing the Welcome Screen (http://localhose:9000/settings/server/wizard.html)I selected the various language options. For Hebrew, the text showed as English (left justified) For the VERY NEXT language selected, the text showed as Right Justified NOTE: This will happen only after selecting Hebrew first, then another language
Update, Windows XP first run wizard has the same issue
The reason that page doesn't display in Hebrew is because we don't have Hebrew translations for the wizard text. Maybe we should simply remove Hebrew from the list of choices in the wizard? Here is a patch to fix the issue where Hebrew isn't RTL and the language selected after Hebrew is RTL, although this is meaningless without a Hebrew translation. Dean: How come we no longer have things translated into Hebrew anyway? --- Slim/Web/Settings/Server/Wizard.pm (revision 29818) +++ Slim/Web/Settings/Server/Wizard.pm (local) @@ -68,9 +68,6 @@ sub handler { my ($class, $client, $paramRef, $pageSetup, $httpClient, $response) = @_; - # set right-to-left orientation for Hebrew users - $paramRef->{rtl} = 1 if ($serverPrefs->get('language') eq 'HE'); - $paramRef->{languageoptions} = Slim::Utils::Strings::languageOptions(); # The hostname for SqueezeNetwork @@ -112,10 +109,14 @@ # handle language separately, as it is in its own form if ($paramRef->{saveLanguage}) { + $log->debug( 'setting language to ' . $paramRef->{language} ); $serverPrefs->set('language', $paramRef->{language}); } $paramRef->{prefs}->{language} = Slim::Utils::Strings::getLanguage(); + + # set right-to-left orientation for Hebrew users + $paramRef->{rtl} = 1 if ($paramRef->{prefs}->{language} eq 'HE'); foreach my $namespace (keys %prefs) { foreach my $pref (@{$prefs{$namespace}}) {
Arg, I didn't realize that we weren't continuing Hebrew translations in 7.0. Ok, please remove hebrew from the wizard screen but leave it in the server settings with the other non-primary translations.
OK, fixed in change 17696.
Verified fixed