Bug 7236 - Fully implement drag and drop on favorites
: Fully implement drag and drop on favorites
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Web Interface
: 7.0
: PC Windows XP
: P2 enhancement (vote)
: 7.x
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-02-20 00:25 UTC by Simon Turner
Modified: 2009-09-08 09:15 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Turner 2008-02-20 00:25:19 UTC
Currently the ability exists in favourites to create a folder. It would be useful if any existing favourites could be dragged and dropped onto this folder. The current method of getting favourites into the new folder is time-consuming, fiddly and not immedicately obvious. IT would be extremely useful for users of internet radio and enable users to create their own single menu system.

In addition it could be handy allow the ability for a favourite to be added within an existing folder. Currently a new favourite can only be created at the top level.
Comment 1 Blackketter Dean 2008-02-20 06:06:36 UTC
Michael: is this  a 7.0.1 or a 7.1 enhancement (wrt the new JS toolkit)?
Comment 2 Michael Herger 2008-02-20 06:37:31 UTC
new feature, no 7.0.x change (or rather two new features)
Comment 3 Adrian Smith 2008-02-20 11:57:28 UTC
I'd hope drag and drop into a different menu level is simple, though we may need a .. or "parent" menu entry to allow items to be moved up the tree.

Adding directly to a menu level would be more complex as it requires a new ui step to ask where is should go when you add an item to favorites.  I'd make this lower priority.
Comment 4 Michael Herger 2008-04-30 12:58:48 UTC
Triode - d'n'd into a folder should be feasible. But I'd need to know whether a target is a folder or not. All I seem to have in the skin is: audio, index, hotkey, url, title, edit, outline. Is there an easy way I could recognize whether a value is a folder or not? "!(url || audio)" sounds like a lot of guessing.
Comment 5 Adrian Smith 2008-04-30 13:19:35 UTC
I think you should see entry.outline too which will be undef for leaves but a set for folders.
Comment 6 Michael Herger 2008-04-30 13:34:45 UTC
> I think you should see entry.outline too which will be undef for leaves but a
> set for folders.

Unless the folder is empty? I'll play with this. Worst which can happen is we send an illegal command to the server which (hopefully) will be ignored.
Comment 7 Jim McAtee 2008-05-03 21:44:25 UTC
Not sure if it's mentioned or implied... The ability to drag-n-drop to change ordering is also needed.  Right now (unless I'm missing something in the interface) the order is fixed.

For the drag-n-drop to a folder, you should also add a "parent" folder icon to all sub-folders so that you can easily move favorites up a level.
Comment 8 Marc Auslander 2008-05-04 08:39:32 UTC
In 7.1, once you open the favorites for editing in the web interface, drag to reposition works.
Comment 9 Michael Herger 2008-05-04 15:27:07 UTC
change 19419 - adding d'n'd on sub-folders and parent levels:
sub-folder: when hovering over a sub-folder, the drop target element will be highlighted with a dark background
parent level: drag the favorite to the crumblist and drop it on the level you want it to be
Comment 10 Michael Herger 2008-05-05 02:28:46 UTC
change 19424 - dropping several levels up now working.
Comment 11 Chris Owens 2008-07-30 15:30:36 UTC
This bug has now been fixed in the 7.1 release version of SqueezeCenter!  Please download the new version from http://www.slimdevices.com if you haven't already.  

If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Comment 12 Chris Owens 2009-07-31 10:17:28 UTC
Reduce number of active targets for SC