Bugzilla – Bug 7225
MP3 streams that don't send content-type header fail
Last modified: 2009-09-08 09:19:04 UTC
Example stream: http://81.149.63.45:8080/listen.pls Patch: --- Slim/Player/Protocols/HTTP.pm (revision 29591) +++ Slim/Player/Protocols/HTTP.pm (local) @@ -262,6 +262,9 @@ my ($title, $bitrate, $metaint, $redir, $contentType, $length, $body); + # Default contentType to audio/mpeg as some servers don't send the type + $contentType = 'audio/mpeg'; + foreach my $header (@headers) { logger('player.streaming.direct')->debug("header-ds: $header");
I have no problem to defaulting to audio/mpeg...but do we care about non-mpeg streams that don't send a content-type header?
I'm not aware of any non-mp3 streams that don't send content-type. BTW, we already had this default to audio/mpeg (Squeezebox2.pm line 339), but since I added a parseDirectHeaders method to Protocols::HTTP it was getting reset to undef.
okay. IMO, commit it. Dean?
Let's put it into trunk. No need to risk 7.0 at this point. Anybody with this issue can get the trunk nightly. Sound ok?
Fixed in change 17649.
*** Bug 7423 has been marked as a duplicate of this bug. ***
Verified fixed with SqueezeCenter Version: 7.0.1 - 19522
This bug has recently been fixed in the latest release of SqueezeCenter 7.0.1 Please try that version, if you still see the error, then reopen this bug. To download this version, please navigate to: http://www.slimdevices.com/su_downloads.html
Reduce number of active targets for SC