Bug 7211 - On Jive displays, don't try displaying the artwork for 'No album'
: On Jive displays, don't try displaying the artwork for 'No album'
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Player UI
: unspecified
: PC Windows XP
: -- enhancement (vote)
: 7.x
Assigned To: Ben Klaas
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-02-18 12:04 UTC by Justin Fletcher
Modified: 2009-07-31 10:17 UTC (History)
0 users

See Also:
Category: ---


Attachments
Patch for Slim/Control/Queries.pm to remove the artwork from 'No album' results. (1.08 KB, patch)
2008-02-18 12:05 UTC, Justin Fletcher
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Fletcher 2008-02-18 12:04:37 UTC
Description:

When the search query returns details for the searches to Jive it returns an artwork id. The artwork id is the first artwork which is valid for the resulting search (I think). Because in my case I have artwork for '2 Unlimited' and all their tracks are from 'No album' (ie no album named), *everything* that is grouped as 'No album' is given the artwork for 2 Unlimited. This makes looking at some albums a little odd. For example, looking at Madonna's albums I've got 'No album' with a picture of 2 Unlimited beside it.

This patch changes the behaviour to remove the artwork IFF the album is the 'No album' entry.

Implementation:

Before we do the loop processing the result set we remember what the text is for the 'No album' string.
When we're returning the artwork identifier we check if the item name matches the 'No album' string.
If it doesn't match, we return the artwork.
If it does match, we don't return any artwork.


Testing:

Locate Madonna in the collection.
See that the 'No album' entry now has a bland 'note' icon, and not the scary '2 Unlimited' icon.
Comment 1 Justin Fletcher 2008-02-18 12:05:17 UTC
Created attachment 2911 [details]
Patch for Slim/Control/Queries.pm to remove the artwork from 'No album' results.
Comment 2 Blackketter Dean 2008-02-18 12:27:05 UTC
Looks good.  Please commit to trunk.
Comment 3 James Richardson 2008-04-09 09:14:36 UTC
Justin:  Have you had a chance to post this into Trunk yet? if so, what is the change number.

Thanks :)
Comment 4 Justin Fletcher 2008-04-09 09:54:48 UTC
I don't have svn write access; if you want me to commit it I'll be happy to... if I could find out how :-)

I assumed that Dean's comment was directed at someone with write access, not at me :-|
Comment 5 Ben Klaas 2008-04-15 09:11:58 UTC
sorry for the delay, Justin, and thanks for the patch.

Tested and verified as fixed, SC trunk 7.0, change 18791
Comment 6 James Richardson 2008-05-08 15:30:24 UTC
Verified fixed in 7.0.1 - 19325  r2409 - r23
Comment 7 James Richardson 2008-05-15 12:28:07 UTC
This bug has recently been fixed in the latest release of SqueezeCenter 7.0.1

Please try that version, if you still see the error, then reopen this bug.

To download this version, please navigate to: http://www.slimdevices.com/su_downloads.html
Comment 8 Chris Owens 2009-07-31 10:17:25 UTC
Reduce number of active targets for SC