Bug 721 – Shoutcast plugin writing directly into /

Bug 721 - Shoutcast plugin writing directly into /

Summary:

Shoutcast plugin writing directly into /

Status:	RESOLVED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Plugins
Version:	5.x or older
Platform:	PC All

Importance:	P2 normal (vote)
Target Milestone:	---
Assigned To:	KDF

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2004-12-09 14:06 UTC by TGL
Modified:	2008-12-18 11:53 UTC (History)
CC List:	0 users

See Also:
Category:	---

Attachments
dont write if no playlistdir (1.52 KB, patch) 2004-12-09 20:03 UTC, KDF	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description TGL 2004-12-09 14:06:14 UTC

Hi,

A small bug in the Shoutcast plugin: when the "playlistdir" preference is not
set (for instance on first run), it creates its ShoutcastBrowser_Recently_Played
directory on the root of the file system (if run as root sure). Actually there
is no check for this case around line 156: 
my $recent_dir = catdir(Slim::Utils::Prefs::get('playlistdir'), $recent_dirname);

Comment 1 KDF 2004-12-09 20:03:11 UTC

Created attachment 226 [details]
dont write if no playlistdir

hoepfully this works.  I'm not able to test or commit since both ultraEdit and
BBEdit, despite both being utf-8 aware, see only able to totally mess up the
files beyond usability :(

Comment 2 TGL 2004-12-10 05:26:16 UTC

The patch didn't apply because of different indentation and because i was not
using the cvs version (rev 1.16) but the 5.4.0 one (rev 1.15), but i've applied
it by hand and it works just very fine. 

Thanks.

Comment 3 Blackketter Dean 2005-03-11 15:30:19 UTC

KDF:  can you ressurct this patch?

Comment 4 KDF 2005-03-11 19:03:08 UTC

committed to r2433

Comment 5 Chris Owens 2008-12-18 11:53:19 UTC

Routine bug db maintenance; removing old versions which cause confusion.  I apologize for the inconvenience.