Bug 7205 - Choose language popup doesn't work
: Choose language popup doesn't work
Status: CLOSED FIXED
Product: MySqueezebox.com
Classification: Unclassified
Component: Web UI
: unspecified
: Macintosh Other
: P1 major (vote)
: ABBA
Assigned To: Andy Grundman
:
Depends on: 7212
Blocks:
  Show dependency treegraph
 
Reported: 2008-02-18 10:07 UTC by Blackketter Dean
Modified: 2008-05-15 12:28 UTC (History)
4 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Blackketter Dean 2008-02-18 10:07:08 UTC
I see SN in english, but the popup on the top bar says Deusch and when I change it to something else, it has no effect.
Comment 1 Michael Herger 2008-02-18 23:23:28 UTC
consider this a duplicate of bug 7212: the drop down imho works perfectly well. But lack of localization very little will change when you switch language. But eg. the start pages "Next" and "Cancel" buttons are localized for me in German, French etc.
Comment 2 Blackketter Dean 2008-02-19 06:54:51 UTC
I see, the popup DOES fail to work on the homepage when logged in with my account and using OmniWeb as a browser.  The player frame appears to reload, but the rest of the UI does not.

On other browsers, it appears to work better (Safari, FF)

Since we have a mostly broken localization, we should disable the pop-up before we ship unless we have a complete translation.  
Comment 3 Blackketter Dean 2008-02-19 18:44:56 UTC
Ok, here's the plan:

1.  Disable the language pop-up now, for GateX and initial ship.

2.  Get the translations updated and re-enable the language selector on the new www.beta.squeezenetwork.com after we ship and install the new languages to be tested in that environment.

Michael, will you do the honors?


Comment 4 Michael Herger 2008-02-20 00:58:16 UTC
language selector disabled in change 2649
Comment 5 Michael Herger 2008-03-12 11:11:08 UTC
change 2914 - adding DE, IT, NL translations
Comment 6 Michael Herger 2008-03-13 05:11:53 UTC
change 2917 - DE, IT, NL, FR, ES done. Good start, but we'll soon need a 2nd pass for the new and changed strings since we sent off the first batch. Mickey? Shall we run a 2nd pass before we release this? 

Translators want a machine to test on...
Comment 7 Andy Grundman 2008-03-14 09:13:05 UTC
Re-targetting SN 7.0.1 bugs to ABBA release.
Comment 8 Michael Herger 2008-03-19 08:27:03 UTC
external users are successfully reviewing different languages - selector seems to be working again.
Comment 9 James Richardson 2008-04-16 12:16:12 UTC
The drop down language selector at the TOP of the page appears to be broken.  When I select a language, it will not change, it will snap back to the previous language.

Changing the language via Account > Language does change the language.

Tested IE / FF / Opera / Safari.

NOTE: if you are currently at Account page when attempting to use the top drop down, then you are prompted for a password, if you put in your current password, it will work.
Comment 10 Michael Herger 2008-04-16 12:25:10 UTC
Are you talking about the language on the web- or the player interface?

IMHO this is first of all _very_ confusing.
Comment 11 Michael Herger 2008-04-17 01:03:53 UTC
Andy - do you know why we swapped the two calls to determineLanguage. Haven't found out what exactly the check-in was (was a merge from some other branch). But with the current order SN will always take the value from the DB if available. Reverting the call to what it was a while back fixes this issue. Any reason not to do so?

Index: /Users/mh/Documents/workspace/SN/lib/SDI/SqueezeNetwork.pm
===================================================================
--- /Users/mh/Documents/workspace/SN/lib/SDI/SqueezeNetwork.pm	(revision 3202)
+++ /Users/mh/Documents/workspace/SN/lib/SDI/SqueezeNetwork.pm	(working copy)
@@ -127,7 +127,7 @@
 sub auto : Private {
 	my ( $self, $c ) = @_;
 	
-	$c->forward( 'determineLanguage' );
+#	$c->forward( 'determineLanguage' );
 	
 	# Bypass for API calls and for /check_service
 	return 1 if $c->req->path =~ /^(?:api|check_service)/;
@@ -224,7 +224,7 @@
 	$c->forward( 'getCountry' );
 	
- 	# XXX: This is already run above in auto()
-	# $c->forward( 'determineLanguage' );
+	$c->forward( 'determineLanguage' );
 	
 	if ( $c->req->action !~ /^(?:user|api)/ ) {
 		if( !$c->stash->{user}->isRegistered ) {
Comment 12 Andy Grundman 2008-04-17 05:19:56 UTC
Yes I moved it up to support Accept-Language for the API.
Comment 13 Andy Grundman 2008-04-17 05:21:06 UTC
I'll fix it so if you are logged in and change that option it changes the value in the DB.
Comment 14 Andy Grundman 2008-04-17 06:15:33 UTC
Fixed in r3208.
Comment 15 James Richardson 2008-04-17 07:58:24 UTC
Verified addressed in ABBA
Comment 16 James Richardson 2008-05-15 12:28:06 UTC
This bug has recently been fixed in the latest release of SqueezeCenter 7.0.1

Please try that version, if you still see the error, then reopen this bug.

To download this version, please navigate to: http://www.slimdevices.com/su_downloads.html