Bug 7157 - Firmware upgrades fail due to tcp corruption
: Firmware upgrades fail due to tcp corruption
Status: CLOSED FIXED
Product: SB Controller
Classification: Unclassified
Component: Setup
: unspecified
: PC Windows XP
: -- normal (vote)
: 7.0
Assigned To: Richard Titmuss
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-02-15 01:09 UTC by Richard Titmuss
Modified: 2009-09-08 09:12 UTC (History)
3 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Titmuss 2008-02-15 01:09:16 UTC
Brandon found this:

the driver source sets a flag on inbound packets to tell the kernel hardware already did the checksumming unconditionally. So I guess in theory the card hardware is handling it. with this kernel patch, jive can tolerate network corruption like it should, at least in my testing here:

Index: os/linux/os_macros.h
===================================================================
--- os/linux/os_macros.h	(revision 3790)
+++ os/linux/os_macros.h	(working copy)
@@ -84,7 +84,7 @@
 
     skb->dev = priv->wlan_dev.netdev;
     skb->protocol = eth_type_trans(skb, priv->wlan_dev.netdev);
-    skb->ip_summed = CHECKSUM_UNNECESSARY;
+    skb->ip_summed = CHECKSUM_NONE;
 
     netif_rx(skb);
Comment 1 Richard Titmuss 2008-02-15 02:25:36 UTC
Fixed in r1967.

This will be a problem with the MP firmware, but if people see repeated firmware upgrade failures from SN the options are:
1) Download and upgrade using SC
2) Download and upgrade using SD card
Comment 2 Richard Titmuss 2008-02-15 10:08:13 UTC
Reopening the bug as the change has been reverted to allow testing bit errors on people home networks.
Comment 3 Blackketter Dean 2008-02-18 08:12:02 UTC
Let's get that patch back in and close this.  I think we've had enough testing.
Comment 4 Blackketter Dean 2008-02-18 12:24:54 UTC
Once fixed, we'll need to confer with support on how we'll handle folks who need help upgrading when connecting directly to SN for the first time AND have such bad internet connections that they can't upgrade.
Comment 5 Richard Titmuss 2008-02-18 13:42:12 UTC
Fixed in r1981.
Comment 6 James Richardson 2008-05-15 13:03:52 UTC
This bug has recently been fixed in the latest release of SqueezeCenter 7.0.1

Please try that version, if you still see the error, then reopen this bug.

To download this version, please navigate to: http://www.slimdevices.com/su_downloads.html