Bugzilla – Bug 7122
Favorites will not save to SN, using Jive
Last modified: 2009-09-08 09:15:39 UTC
Using the Jive to add favorites when connected to SN will not save. Steps to Reproduce 1. Connect a Jive & Ray to beta.SqueezeNetwork.com 2. Using the Jive, attempt to add something to your Favorites a. click on Internet Radio b. click on Radio IO c. click on any channel d. click on Add to Favorites e. click on Add Note: The JIVE UI will now show Delete Favorite where ADD was before. So, it looks like the favorites were added properly If you jump back to the HOME menu, then scroll to Favorites, you will notice the UI show EMPTY, not the tracks you have added. ALSO, if you go to the SN Web UI, no favorites have been added to the Favorites Screen.
This bug MAY be related to bug 7118 as well, but I'm not sure
Saving Favorites using the SN WEB UI works now, there was a code push to SN this after noon that fixed that. However, using the JIVE to save still does not work. They show as saved on the Jive (not in the favorites folder, but in the stream description) but do not show up on the SN WEB UI or in the Favorites folder on the Jive.
James, if this works with SC, then lets' move the bug to the SN product.
This is a SN only bug, as this works with SC 7.0 -17491
Andy: is this yours?
Probably a bug in the SC favorites code, but I will look at it since SN does favorites a bit differently.
This is more complex than I first thought, the problem is all of the SC favorites code assumes the favorites are stored in an OPML file, but on SN they are stored in the database. There's an abstraction layer Slim::Utils::Favorites but it's not being used for everything, and there are additional features the abstracted API doesn't have such as 'rename', 'move', and 'addlevel'. I'm not even sure these are used, Ben? All the SN class supports are basically add and delete.
Jive right now only uses 'add' and 'delete' for favorites support. I'm not going to be much help in understanding the nature of the Slim::Utils::Favorites abstraction layer. I don't understand how the pieces fit together, and since there is such a strong opinion that it needs to be completely re-organized post 7.0, I haven't spent any time trying to figure out how it works.
OK, I'm only going to have SN support add and delete then. Do you know why move, rename, and addlevel are there?
sorry, beyond the scope of my favorites knowledge. cc:ing Michael, who may know
Fixed in SC change 17577 and SN r17583.
Verified fixed in SqueezeNetwork r2623/r17641