Bug 7109 - Adding 'Play All' item to XMLBrowse menus is misaligning commands with menu items
: Adding 'Play All' item to XMLBrowse menus is misaligning commands with menu i...
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: SqueezeNetwork Integration
: unspecified
: PC Windows XP
: -- normal (vote)
: ---
Assigned To: Andy Grundman
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-02-12 17:04 UTC by Mickey Gee
Modified: 2009-09-08 09:22 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mickey Gee 2008-02-12 17:04:53 UTC
Selecting on album "Lang Lang - Live at Carnegie Hall" from my Rhapsody library I get the list of tracks. If I scroll to the bottom I see "Rating: None". When I select "Rating: None" I see a new screen titled "Rating: None" which says "Album removed from library". I also a pop-up with the same message. Hey -- I didn't want to do that!

When I back out to My Library on Rhapsody and select Albums, the album is indeed no longer in my library.

Using Jive firmware 7.0 r1915 Feb 12 2008.
Comment 1 Blackketter Dean 2008-02-12 19:27:21 UTC
Andy/Ben: Any thoughts?
Comment 2 Andy Grundman 2008-02-12 20:57:37 UTC
Weird, I will look at this tomorrow.
Comment 3 Ben Klaas 2008-02-13 09:58:11 UTC
Andy, my guess is that stuff got munged when you added the 'Play All' item at the top.

If I descend into a Rhapsody album and go down to say, track 18 and hit play, track 17 plays.
Comment 4 Ben Klaas 2008-02-13 09:58:57 UTC
sorry, check that. If I hit play on track 17, track 18 plays.
Comment 5 Andy Grundman 2008-02-13 10:06:31 UTC
Ugh, that's probably it.
Comment 6 Ben Klaas 2008-02-13 10:09:09 UTC
the business of inserting items into a chunked menu response is a little tricky. No, a lot tricky...

take a look at how the _playAll stuff is done in Queries.pm, esp. with respect to adjusting all the misc values associated with the chunked response ($start, $end, $valid, $cnt, $totalCount, etc.)

let me know if I can clarify anything...
Comment 7 Andy Grundman 2008-02-13 10:50:54 UTC
Fixed in change 17509.
Comment 8 Chris Owens 2008-03-07 09:03:32 UTC
This bug is being closed since it was resolved for a version which is now released!  Please download the new version of SqueezeCenter (formerly SlimServer) at http://www.slimdevices.com/su_downloads.html

If you are still seeing this bug, please re-open it and we will consider it for a future release.