Bug 7089 - Items in Extras Menu are not ordered correctly
: Items in Extras Menu are not ordered correctly
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Player UI
: 7.0
: PC Windows XP
: -- minor (vote)
: 7.x
Assigned To: KDF
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-02-12 00:21 UTC by Philip Meyer
Modified: 2009-09-08 09:31 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philip Meyer 2008-02-12 00:21:35 UTC
There are 3 built-in plugins appearing at the top of the Extras menu, followed by all of the other plugins (a mix of built-in plugins and third-party plugins):

Podcasts
RSS News Ticker
Sounds & Effects
Album Review
Biography
...


Shouldn't the list be completely alphabetical?
Comment 1 KDF 2008-02-12 08:22:03 UTC
it's currently weighted as per current design spec, with third party plugins defaulting to end of list when a weight isn't provided.
Comment 2 KDF 2008-03-27 09:20:03 UTC
need UI design decision on this one.  
Comment 3 Brian Dils 2008-03-28 09:52:39 UTC
I think I'd prefer an alphabetical list for now because without doing some user research, there's no real way to determine what order it should be in that would be best for the user
Comment 4 KDF 2008-03-28 10:46:26 UTC
This gets rid of the use of sorting by rank prefs

Index: C:/slim/server/Slim/Buttons/Home.pm
===================================================================
--- C:/slim/server/Slim/Buttons/Home.pm	(revision 18130)
+++ C:/slim/server/Slim/Buttons/Home.pm	(working copy)
@@ -527,9 +527,7 @@
 
 	my @list = ();
 
-	for my $sub (sort {(($prefs->get("rank-$b") || 0) <=> 
-		($prefs->get("rank-$a") || 0)) || 
-		(lc(cmpString($client, $a)) cmp lc(cmpString($client, $b)))} 
+	for my $sub (sort {(lc(cmpString($client, $a)) cmp lc(cmpString($client, $b)))} 
 		keys %{$params->{'submenus'}}) {
 
 		# Leakage of the DigitalInput plugin..
Comment 5 Andy Grundman 2008-03-28 10:52:26 UTC
It's Dean's call.
Comment 6 Blackketter Dean 2008-03-30 23:19:17 UTC
Please sort alphabetically.

KDF will you do the honors?
Comment 7 KDF 2008-03-31 09:41:25 UTC
change 18233, hopefully to the correct repo :)
Comment 8 Andy Grundman 2008-04-03 06:33:12 UTC
This is no good, I thought we were following Dean's order listed here: http://wiki.slimdevices.com/index.cgi?UserInterfaceHierarchy

Music Library especially is all messed up now.  And having Staff Picks as the last item in Radio feels wrong.
Comment 9 KDF 2008-04-03 08:23:43 UTC
gagh.  I hate all this redefining lately.  These will have to use the same weighting system used with squeezeplay so that weighted menus will work just like the controller/web views, while Extras menu alone remains asphbetical
Comment 10 KDF 2008-04-03 08:41:19 UTC
reverted 18233 for now. sorry.
Comment 11 KDF 2008-04-03 12:40:08 UTC
change 18346 does a better job, sorting only the extras menu alphabetically.  This sticks with the wiki in all other menus and matches what the web and squeezeplay UIs are doing.  Leaving open for now in case someone prefers it to be done in a different way.
Comment 12 Andy Grundman 2008-04-03 12:41:03 UTC
Thanks, I think this will probably be fine, so marking fixed.
Comment 13 James Richardson 2008-05-08 13:54:06 UTC
(In reply to comment #12)
> Thanks, I think this will probably be fine, so marking fixed.
> 

Marking bug as closed, unless we want to do more redefining of the spec
Comment 14 Chris Owens 2009-07-31 10:17:00 UTC
Reduce number of active targets for SC