Bugzilla – Bug 7088
No Album under specific artist shows all songs that don't have an album assigned of any artist
Last modified: 2009-09-08 09:15:14 UTC
I'm playing a song by a certain artist, I press the center button on the Controller (from the now playing screen) to go to the details screen and select "Artist". A number of albums by that artist are shown, amongst them a 'No Album' entry for tracks that don't have an album tag assigned. When I select that entry I get a list of all tracks without album tags assigned of any artist, which is a list of hundreds. When I do the same operations on my SB3 with the standard remote, the 'No Album' list is nicely restricted to the artist in question, so this seems to be a bug in the Jive software that loses the artist context somehow. The same problem occurs when just browsing by artist and selecting 'No Album'. Considering this, it's probably likely that the same problem will occur when you have two artists who have the same album title, but I didn't test this. squeezecenter-7.0-0.2.17388 Jive 7.0 r1901
Michael: can you take a look at this?
Created attachment 2850 [details] only display a contributor's tracks for a given album id
Please review patch and commit if it seems fine to you. Please note that I think we should go through all browser hierarchies in all interfaces and make sure the behave the same on all of them. I could imagine we have the same issue in other browse modes, too. We should probably make sure we're passing all IDs come along while descending a hierarchy to any given level.
Andy, can you review this patch?
Patch applied as change 17485.
Patch doesn't quite look right to me; if ($contributorID) should probably be if (defined $contributorID) unless $contributorID is never allowed to be 0.
thanks Justin - change 17533
I just checked the 17533 version and when I take the path I described above it works the way it should. But if I play one of the songs without an album tag and go via Now Playing to the details screen and then select "Album: No Album" the same long list appears with tracks from other artists.
Index: Slim/Buttons/TrackInfo.pm =================================================================== --- Slim/Buttons/TrackInfo.pm (revision 17564) +++ Slim/Buttons/TrackInfo.pm (working copy) @@ -489,7 +489,10 @@ Slim::Buttons::Common::pushMode($client, 'browsedb', { 'hierarchy' => 'album,track', 'level' => 1, - 'findCriteria' => { 'album.id' => $curObj->id }, + 'findCriteria' => { + 'album.id' => $curObj->id, + 'contributor.id' => ( blessed $contributor ) ? $contributor->id : undef, + }, 'selectionCriteria' => $selectionCriteria, });
andy/michael, can you review this patch?
Patch looks fine to me.
KDF: please commit to the 7.0 branch. Thx!
change 17571
This bug has recently been fixed in the latest release of SqueezeCenter 7.0.1 Please try that version, if you still see the error, then reopen this bug. To download this version, please navigate to: http://www.slimdevices.com/su_downloads.html