Bugzilla – Bug 7085
infobrowser items are empty
Last modified: 2009-09-08 09:11:58 UTC
when descending to the last level of infobrowser, the items come up blank, with the following error in jive console: 191616:40774 ERROR (RequestHttp.lua:67) - Response sink:...share/jive/applets/InfoBrowser/InfoBrowserApplet.lua:107: bad argument #1 to 'pairs' (table expected, got nil) stack traceback: ...ne/jive/build/osx/share/jive/jive/utils/coxpcall.lua:28: in function <...ne/jive/build/osx/share/jive/jive/utils/coxpcall.lua:26> (tail call): ? (tail call): ? (tail call): ? ...e/jive/build/osx/share/jive/jive/net/RequestHttp.lua:64: in function 'snk' ...sers/fishbone/jive/build/osx/share/lua/5.1/ltn12.lua:262: in function 'mySink' .../jive/build/osx/share/jive/jive/net/CometRequest.lua:135: in function 't_setResponseBody' ...ne/jive/build/osx/share/jive/jive/net/SocketHttp.lua:596: in function 'snk' ...sers/fishbone/jive/build/osx/share/lua/5.1/ltn12.lua:277: in function 'step' ...ne/jive/build/osx/share/jive/jive/net/SocketHttp.lua:662: in function 'pump' ...one/jive/build/osx/share/jive/jive/net/SocketTcp.lua:202: in function 'readPump' ...shbone/jive/build/osx/share/jive/jive/net/Socket.lua:143: in function <...shbone/jive/build/osx/share/jive/jive/net/Socket.lua:141> This seems to start being a problem as of SC change 17354 which is a response to bug 7024. fix appears to be a partial reversion of that change: Index: Slim/Buttons/XMLBrowser.pm =================================================================== --- Slim/Buttons/XMLBrowser.pm (revision 17424) +++ Slim/Buttons/XMLBrowser.pm (working copy) @@ -1377,6 +1377,8 @@ # This is a leaf item, so show as much info as we have and go packing after that. if ( $isItemQuery && ( + !defined($subFeed->{'items'}) || + scalar(@{$subFeed->{'items'}}) == 0 || $subFeed->{'type'} eq 'audio' || $subFeed->{'enclosure'} ) This, however, means bug 7024 isn't fixed right, so it may be that infobrowser applet needs a tweak. It's awfully hard to track matching changes between SC and Jive.
here is a possible fix: Index: Slim/Buttons/XMLBrowser.pm =================================================================== --- Slim/Buttons/XMLBrowser.pm (revision 17424) +++ Slim/Buttons/XMLBrowser.pm (working copy) @@ -1377,6 +1377,7 @@ # This is a leaf item, so show as much info as we have and go packing after that. if ( $isItemQuery && ( + $subFeed->{'description'} || $subFeed->{'type'} eq 'audio' || $subFeed->{'enclosure'} ) However, I cannot test it's effects on bug 7024 as it pertains to Rhapsody and an artist with no items. If there is a description value, this will clearly be an issue. If not, then it should be a fix. As I am too far north to be affected by Rhapsody, the above fix works here :)
Triode & Andy: what do you think?
Andy: what do you think of this patch?
I agree with kdf's patch. change 17353 stops sending infobrowser data for the leaf nodes. Adding this back in if there is a description fixes it - shall I commit?
Yeah, that patch looks fine.
Fixed in change 17447
This bug is being closed since it was resolved for a version which is now released! Please download the new version of SqueezeCenter (formerly SlimServer) at http://www.slimdevices.com/su_downloads.html If you are still seeing this bug, please re-open it and we will consider it for a future release.