Bug 7071 - Jive, Rhapsody: Album says empty when there is only 1 song.
: Jive, Rhapsody: Album says empty when there is only 1 song.
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: XML
: unspecified
: PC Other
: P1 major (vote)
: ---
Assigned To: Andy Grundman
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-02-10 23:26 UTC by Wallace Lai
Modified: 2009-09-08 09:11 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Wallace Lai 2008-02-10 23:26:45 UTC
Jive FW:  7.0 r1853

Steps to Repoduce:
1.  Go to Rhapsody and search for an artist.
2.  Go to top tracks for the artist.
3.  Find a song from an album that is not already in the library.  Add the song to the library.  This is to ensure there is only one song in that album. 
4.  Go to my library and pick that artist, then pick that particular album with the center button.  (Not the play button.)
5.  When Jive's page is inside that album, notice it says empty.

Work Around:
On the art work of the album, press the play button instead of the center button.  The song will play.  However, the user needs to know what song is in that album.  The song's title is no where to be found until the play button is pressed.  The title of the song shows when Jive starts gathering the track's info.
Comment 1 Blackketter Dean 2008-02-11 07:10:32 UTC
This is a SN bug, right Andy?
Comment 2 Andy Grundman 2008-02-11 07:23:45 UTC
No it's probably an XMLBrowser bug.
Comment 3 Andy Grundman 2008-02-11 08:12:37 UTC
Fixed in change 17398.

Triode: I had to change a bit of your code here, the code that was automatically displaying 1-item playlists as leaf items was causing this.
Comment 4 Adrian Smith 2008-02-11 12:12:07 UTC
I think this will break Alien - well create another menu level for this which is most unnatural.  Let me test and see.

Is it need in both the remotetrackinfo case and just pushing into the track?
Comment 5 Andy Grundman 2008-02-11 12:15:57 UTC
I would like the menus to reflect the actual OPML structure.  If it will break Alien I think it's something you should fix in the Alien OPML.
Comment 6 Andy Grundman 2008-02-11 12:16:50 UTC
The use case here is a single-item Rhapsody album.  With the previous code you could not drill down into track details because the menu was taken over by the final detail screen.
Comment 7 Adrian Smith 2008-02-11 12:28:58 UTC
Yes this does add an unnecessary and odd looking extra menu level for alien.  The problem is that we need to parse another page to get the info for alien.  I need to look at this again later this week.

How much time do I have for 7.0 - I'd definately like to keep all the alien functionality with 7.0 so would prefer to keep this as is or find time to be certain that Alien can do it another way.  I believe we did the same thing for cli, web and button mode so I do want to keep it if at all possible, or find a way to escape to do it for alien.
Comment 8 Adrian Smith 2008-02-11 12:31:24 UTC
I note you've changed the cli and button code but not the web code....  
Comment 9 Andy Grundman 2008-02-11 12:57:00 UTC
Thanks, you're right.  Fixed in change 17416.
Comment 10 Wallace Lai 2008-02-11 19:44:50 UTC
Verified the fix with Jive FW 7.0 r1913.
Bug as written is no longer seen.  Performed regression tests in the same area.  Nothing seems to be broken by this fix.
Great job.
Marking as "VERIRIED".
Comment 11 Wallace Lai 2008-02-11 19:45:58 UTC
Closed this bug.
Comment 12 Adrian Smith 2008-02-12 12:53:56 UTC
Alternative fix added as change 17449 which does not remove the ability to replace a playlist level (used by Alien)