Bug 7066 – Bad Favorites URLs can't be edited and made playable

Bug 7066 - Bad Favorites URLs can't be edited and made playable

Summary:

Bad Favorites URLs can't be edited and made playable

Status:	CLOSED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Web Interface
Version:	7.0
Platform:	PC Windows XP

Importance:	-- normal (vote)
Target Milestone:	7.x
Assigned To:	Adrian Smith

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2008-02-09 22:26 UTC by Jim McAtee
Modified:	2009-07-31 10:16 UTC (History)
CC List:	3 users (show)

See Also:
Category:	---

Attachments
favorites file (1.50 KB, text/plain) 2008-02-13 11:33 UTC, Jim McAtee	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jim McAtee 2008-02-09 22:26:17 UTC

If you enter an incorrect URL into a favorite, you cannot later edit the URL so that it becomes playable.  The 'Play' control never appears.  Apparently the validity of the entry is checked only when the favorite is created, but not when edited.

Comment 1 Michael Herger 2008-02-13 04:41:11 UTC

Could you please upload that favorites file with an incorrect URL? How does such an URL have to look like? Is http://www.doesntexist.com/ enough?

Comment 2 Jim McAtee 2008-02-13 11:33:48 UTC

Created attachment 2870 [details]
favorites file

Did some more testing, including deleting the favorites.opml file and the problem doesn't seem to be consistent.  Before, I could create a new fav and leave the URL as 'URL'.  Then going back and making it valid, it wouldn't get a play control.  I still have one favorite with the problem, though.

See the attached favorites.opml.  The oddball is in the folder 'Colorado Radio' and has the identical URL of the favorite immediately above it.

Comment 3 Jim McAtee 2008-02-13 11:46:17 UTC

Ok, I see the difference in the opml file.  The missing type="audio" on that entry.  I wonder if it began life as a "non-audio" favorite, if there is such a thing.  Offhand, I can't see how to create one.  Maybe when editing you just need to re-evaluate the type and make sure it's set correctly when saved.

Comment 4 Michael Herger 2008-02-22 01:47:01 UTC

*** Bug 7265 has been marked as a duplicate of this bug. ***

Comment 5 Robert Godfrey 2008-02-29 08:31:33 UTC

For more than a year I have had several favorites that I can't delete from squeezenetwork using the remote (they're dead). Delete never appears for them.

Using 6.5.4

Robert

Comment 6 Adrian Smith 2008-03-02 04:43:58 UTC

I understand what is going on here - we only change the content type of an entry the first time it is added at present.  Hence if you add a bad url and then correct it it won't change the type.

Put this down to me to fix.

Comment 7 Michael Herger 2008-03-02 06:28:26 UTC

Thanks Adrian!

Comment 8 Adrian Smith 2008-03-10 05:32:12 UTC

Fixed in 17837 please verify

Comment 9 James Richardson 2008-05-08 14:08:04 UTC

Verified fixed in 7.0.1 - 19325

There is now a way to edit or delete a favorite from the WEB UI as well as the player(s) UI

Comment 10 James Richardson 2008-05-15 12:27:51 UTC

This bug has recently been fixed in the latest release of SqueezeCenter 7.0.1

Please try that version, if you still see the error, then reopen this bug.

To download this version, please navigate to: http://www.slimdevices.com/su_downloads.html

Comment 11 Chris Owens 2009-07-31 10:16:56 UTC

Reduce number of active targets for SC