Bug 702 – convert.conf does not use $QUALITY$ setting uniformly

Bug 702 - convert.conf does not use $QUALITY$ setting uniformly

Summary:

convert.conf does not use $QUALITY$ setting uniformly

Status:	CLOSED FIXED

Product:	Logitech Media Server
Classification:	Unclassified
Component:	Formats
Version:	5.x or older
Platform:	All All

Importance:	P2 normal (vote)
Target Milestone:	---
Assigned To:	Vidur Apparao

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2004-12-02 00:52 UTC by Craig Eales
Modified:	2008-12-18 11:55 UTC (History)
CC List:	0 users

See Also:
Category:	---

Attachments
Patch to convert.conf 1.31 adds the $QUALITY$ setting to all [lame] calls (2.53 KB, patch) 2004-12-02 00:56 UTC, Craig Eales	Details \| Diff
Source.pm section to go with this. (1.96 KB, patch) 2004-12-03 00:18 UTC, KDF	Details \| Diff
MMS Protocol handler patch (1.15 KB, patch) 2004-12-04 09:58 UTC, Vidur Apparao	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Craig Eales 2004-12-02 00:52:15 UTC

The quality of the lame stage of the pipelines in convert.conf is not
consistently set with the new $QUALITY$ flag. In fact the ogg mp3 transform does
not have any quality setting at all, most of the others are hard coded at 9.

Comment 1 Craig Eales 2004-12-02 00:56:30 UTC

Created attachment 215 [details]
Patch to convert.conf 1.31 adds the $QUALITY$ setting to all [lame] calls

This patch fixes the missing $QUALITY$ setttings.

Craig

Comment 2 KDF 2004-12-02 01:29:08 UTC

merged to main cvs, but needs to be added to the 5.4.x branch.

Comment 3 Vidur Apparao 2004-12-02 18:23:06 UTC

The quality setting isn't in the 5.4.x branch...or am I missing something?

Comment 4 KDF 2004-12-03 00:10:33 UTC

if its not, then it could be if you copy the patch from bug663

Comment 5 KDF 2004-12-03 00:15:57 UTC

it seems I missed the part of the patch that needed to be applied to source.pm
as well as convert.conf.

Comment 6 KDF 2004-12-03 00:18:25 UTC

Created attachment 218 [details]
Source.pm section to go with this.

Here is the bit I left out of the patch I sent for 5.4.1.  The settings were
included before.

Comment 7 Vidur Apparao 2004-12-04 09:58:02 UTC

Created attachment 220 [details]
MMS Protocol handler patch

Turns out that this patch was necessary as well. I've committed to CVS trunk
and 5.4.1 branch.

Comment 8 Chris Owens 2007-05-24 15:54:10 UTC

This Slimserver bug was fixed a very long time ago, and is now being marked as Closed.  If you're still experiencing this issue, please verify you are running a current version of Slimserver and re-open the bug.

Comment 9 Chris Owens 2008-12-18 11:55:34 UTC

Routine bug db maintenance; removing old versions which cause confusion.  I apologize for the inconvenience.