Bug 6908 - Need to display XMLBrowser network errors
: Need to display XMLBrowser network errors
Status: CLOSED FIXED
Product: SB Controller
Classification: Unclassified
Component: Browser
: unspecified
: Macintosh Other
: P2 normal (vote)
: 7.0
Assigned To: Ben Klaas
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-02-02 00:11 UTC by Blackketter Dean
Modified: 2008-05-15 13:02 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments
Blank screen with missing error message. (45.68 KB, image/png)
2008-02-02 00:13 UTC, Blackketter Dean
Details
screenshot of bug fix (59.44 KB, image/png)
2008-02-04 20:42 UTC, Ben Klaas
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Blackketter Dean 2008-02-02 00:11:07 UTC
Right now, all it gives you is a blank screen.
Comment 1 Blackketter Dean 2008-02-02 00:13:10 UTC
Created attachment 2802 [details]
Blank screen with missing error message.
Comment 2 Ben Klaas 2008-02-04 08:36:16 UTC
anyone know if this ever worked?

after getting SC to forget my SN login, I turned on comet debugging and dropped into the pandora menu.

When there's no SN information Jive/SC get stuck in a feedback loop and endlessly request the item. Here's one of the thousands that hit the console--

[10:31:21.6737] Slim::Web::Cometd::handler (145) Cometd request: [
  {
    channel => "/slim/request",
    data => {
          request  => [
                        "00:04:20:06:33:d0",
                        ["pandora", "items", 0, 200, "menu:pandora", "item_id:0"],
                      ],
          response => "/85757cac/slim/request",
        },
    id => 1101,
  },
]
[10:31:21.7219] Slim::Buttons::XMLBrowser::_cliQuery_error (1968) Error: While retrieving [http://www.squeezenetwork.com:3000/api/pandora/v1/opml/stations]: [A SqueezeNetwork account is required for this service. Please access SqueezeCenter Settings -> SqueezeNetwork with a web browser to configure.]
[10:31:21.7223] Slim::Web::Cometd::handleRequest (778) Request for /85757cac/slim/request / 1101 is not async
[10:31:21.7227] Slim::Web::Cometd::Manager::deliver_events (209) Sending event on channel /85757cac/slim/request to 85757cac
[10:31:21.7236] Slim::Web::Cometd::Manager::deliver_events (223) Delivering events to 85757cac:
[
  {
    channel => "/85757cac/slim/request",
    data => {
          # tied Tie::IxHash
          count => 0,
          networkerror => 1,
        },
    ext => { priority => "" },
    id => 1101,
  },
]
Comment 3 Andy Grundman 2008-02-04 08:42:22 UTC
OK I guess this never worked, since that particular error is handled like an HTTP error which Jive has no knowledge of, it just gets a 'networkerror' key back.  This may be able to be fixed by letting SC request the real URL and having SN return the proper error message in OPML.  I can try to fix this if you want.

There is still another bug here and that is that any kind of HTTP error is not going to be displayed on Jive.
Comment 4 Andy Grundman 2008-02-04 08:52:45 UTC
On second thought, it doesn't make sense to change the SN code here.  Jive needs to handle the networkerror case anyway, so I'll see about making the networkerror key return the actual error string though, instead of just a 1.
Comment 5 Andy Grundman 2008-02-04 08:54:14 UTC
Change 17170 fixes the networkerror key.
Comment 6 Ben Klaas 2008-02-04 20:42:05 UTC
along with Andy's fix in change 17170, jive r1812 fixes this issue

Description: add textarea window when data.networkerror comes down the browse sink
also fixes endless loop of requests when networkerror occurs
Comment 7 Ben Klaas 2008-02-04 20:42:40 UTC
Created attachment 2816 [details]
screenshot of bug fix
Comment 8 James Richardson 2008-05-15 13:02:53 UTC
This bug has recently been fixed in the latest release of SqueezeCenter 7.0.1

Please try that version, if you still see the error, then reopen this bug.

To download this version, please navigate to: http://www.slimdevices.com/su_downloads.html