Bugzilla – Bug 6897
New Transporter prefs cause log warning and are missing setup for firmware sync
Last modified: 2009-07-31 10:16:37 UTC
Player::Transporter, line 71: $client->getPlayerSetting('fxloopSource'); $client->getPlayerSetting('fxloopClock'); These call a function in Player::Squeezebox2, but since these new prefs aren't set up in $pref_settings, it causes a warning at line 721 due to an unknown value used in pack. This is trunk only., 7.0.1
Sean, does this look familiar to you? Do you know what needs to be done about this?
something like this is needed, but I don't know what the firmwareid should be, given that I assume it must be an internal firmware reference that us third party types are not privy to. Index: C:/slim/7.1/server/Slim/Player/Squeezebox2.pm =================================================================== --- C:/slim/7.1/server/Slim/Player/Squeezebox2.pm (revision 20786) +++ C:/slim/7.1/server/Slim/Player/Squeezebox2.pm (working copy) @@ -708,6 +708,14 @@ firmwareid => 4, pack => 'C', }, + 'fxloopSource' => { # (Transporter only) + firmwareid => 3, + pack => 'C', + }, + 'fxloopClock' => { # (Transporter only) + firmwareid => 3, + pack => 'C', + }, }; $prefs->setChange( sub { my ($pref, $val, $client) = @_; $client->setPlayerSetting($pref, $val); }, keys %{$pref_settings});
Looks like the firmware needs some additional IDs added for the 2 fxloop settings before this can be implemented. Assigning to Felix.
Felix are you back from your vacation yet? It seeems like this needs to get done for 7.1.
I looked at Sean's code and he implemented it differently, i.e. similar to setting the 'digital input' or the 'clock source' on TR. You need to send a 'audf' slimproto command with two parameters (source and clock mode) instead of using 'setd'. This is the code from slimproto_recv.c line 161: case SLIMPROTO_AUDF_RECV: // 'audf' if (netbuf_get_remaining(nb) >= 2) { audio_set_fxloop( netbuf_fwd_read_u8(nb), // source netbuf_fwd_read_u8(nb) // clock mode ); } break;
Hmm, I think since we have 2 prefs in SC we still need 2 separate setd IDs. I think each one would call audio_set_fxloop with whichever value was passed in and the current value of the other parameter.
Added IDs for fxloop_input (id=5) and fxloop_clockmode (id=6) in TR fw 44 (rev 4456)
SC side fixed in 7.1 change 21483.
KDF: please retest with SqueezeCenter 7.1-21796. if you still see the error, then reopen the bug with added comments.
I can't see them any more.
This bug has now been fixed in the 7.1 release version of SqueezeCenter! Please download the new version from http://www.slimdevices.com if you haven't already. If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
This bug has been fixed in the 7.3.0 release version of SqueezeCenter! Please download the new version from http://www.slimdevices.com/su_downloads.html if you haven't already. If you are still experiencing this problem, feel free to reopen the bug with your new comments and we'll have another look.
Reduce number of active targets for SC