Bugzilla – Bug 6895
"Forget this player" for SB Receiver needs a confirmation step.
Last modified: 2009-09-08 09:14:07 UTC
The "Forget this player" link on the Settings->Players->Receiver->Basic Settings page, as it stands know, seems to put the receiver into a state where a complete re-setup is required, starting with a Receiver front chassis button press 'n hold. It would be nice if the user had a chance to regret his or her idly-curious click on that link. Some kind of warning that proceeding will require a complete re-setup of the Receiver would seem to be appropriate.
You shouldn't be able to forget a Receiver if it's connected to your server. Felix, can you take a look at this?
I am confused now, do you want a confirmation box as suggested or should there be no 'Forget Player' link at all for SBRs?
If you don't want to forget an SBR on the local network, it would seem sensible to not forget any hardware on the local network, as they just reconnect. Different if it wiped prefs, but it doesn't.
On second thought, I think KDF is right. Restarting the server DOES cause the SBR to reconnect. Nothing is lost and a re-setup isn't necessary. Perhaps all that is needed is to expand the "[i]" information text to let folks know that all is not lost and a simple server restart will get their Receiver (or SB2,SB3,Transporter, etc.) to reconnect.
That said, what is the "forget this player" feature FOR, if it's really more a case of temporary amnesia?
No, I'm saying that forgetting the player should have no effect. The player may get disconnected, but it should reconnect. The fact that it gets stuck is troublesome.
I believe the behavior hasn't changed. Forgetting a player forgets a player. To get it back connected to SC, either SC needs to be restarted or the player needs to be power-cycled. (I just tried this with an SB and a Ray and they both behave exactly the same.) There is no need to setup the player again. My understanding for this feature is what is does - a player gets cleaned out from SC player list. I think it is mainly meant to clean out double entries. Is that still what we want or should the link on the web interface go away or should the information 'i' say that either the player needs to be power-cycled or SC needs a restart?
As it stands, I assume that this feature mostly addresses the "stream.mp3" clients...and this is how you make one go away after its been set up. As for what this feature "could do", or "should do", or you "might want to have it do this"... I could possibly see the need for an "Ignore this player" feature for the case of a household with multiple SqueezeCenter servers and multiple client players. But, if a player isn't connected to a particular server, but was connected once in the past, does that player still remain the drop-down list of available players on that server? If not, then even this feature is unnecessary. I'm sorry I raised this. I think I'm waisting all of your time here. At most, all you really need to do is provide some information / feedback to potentially panicky users like myself, to reassure them that a Receiver really hasn't gone away completely and that a re-setup is unnecessary.
A while ago I fixed stream.mp3 clients to auto-forget when they disconnect, so maybe this feature is not even useful anymore.
Felix: If I forget my SB3, it comes right back. If I forget my Receiver, it does not. At a minimum, we should remove this link from the Receiver setup page. Excellent point, Andy. I can't think of a reason why we need this now. I'm troubled by this since it's one of the very few basic settings for a Receiver and people are likely to click it just to find out what it does.
So should we remove 'forget this player'?
Removed link for all player types. (SC rev 16751)
This bug is being closed since it was resolved for a version which is now released! Please download the new version of SqueezeCenter (formerly SlimServer) at http://www.slimdevices.com/su_downloads.html If you are still seeing this bug, please re-open it and we will consider it for a future release.