Bug 6887 - wrap = 1 doesn't work for Pandora item "why did you play this song?"
: wrap = 1 doesn't work for Pandora item "why did you play this song?"
Status: CLOSED FIXED
Product: SB Controller
Classification: Unclassified
Component: Browser
: unspecified
: Macintosh Other
: P5 normal (vote)
: 7.0
Assigned To: Ben Klaas
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-01-31 13:48 UTC by Ben Klaas
Modified: 2009-09-08 09:18 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Klaas 2008-01-31 13:48:00 UTC
mine to fix for 7.0
Comment 1 Ben Klaas 2008-02-01 09:32:49 UTC
the reason it doesn't work is that the items array in the parent link is empty. Right now I'm inspecting the first element of items to see if the child window should be rendered as a textarea instead of a menu.

I am investigating being able to render an item in the current window as a textarea when browsing SlimBrowser menus.

[11:20:54.2167] Data::Dump::dump (100) Warning: {
  items => [],
  name  => "Why did you play this song?",
  type  => "link",
  url   => "http://www.squeezenetwork.com:3000/api/pandora/v1/opml/trackinfo/explainTrack?trackId=f70de177a2fa4bd47e7a053eb02ff59d4f6785ef89cea6ff704d0588619e074013c66fc676033061&stationId=6469148503938342",
  value => "http://www.squeezenetwork.com:3000/api/pandora/v1/opml/trackinfo/explainTrack?trackId=f70de177a2fa4bd47e7a053eb02ff59d4f6785ef89cea6ff704d0588619e074013c66fc676033061&stationId=6469148503938342",
}

Comment 2 Andy Grundman 2008-02-01 09:34:17 UTC
Oh, unfortunately you'll have to support it both ways. :\
Comment 3 Ben Klaas 2008-02-01 09:35:45 UTC
yeah, understood.

Richard was doing some things with mixed textarea/menus with the PIN stuff the other day. Gives me hope this won't be too hard.
Comment 4 Ben Klaas 2008-02-01 12:25:29 UTC
fixed in jive r1738 and SC change 17114

FYI-- I've removed the inspection of the items[] array in XMLBrowser and rely completely on seeing if there's a wrap parameter for the item currently being rendered. If there is, the data gets shown as a textarea and all other menu items are excluded.

Checked with Rhapsody album reviews and Pandora "why did you play this song?" and both work fine

(btw, I mistakenly referenced bug 5761 in both of those checkins)
Comment 5 James Richardson 2008-05-15 13:02:49 UTC
This bug has recently been fixed in the latest release of SqueezeCenter 7.0.1

Please try that version, if you still see the error, then reopen this bug.

To download this version, please navigate to: http://www.slimdevices.com/su_downloads.html