Bug 6870 - Can't change player menus
: Can't change player menus
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Web Interface
: 7.0
: PC Windows XP
: P2 normal (vote)
: ---
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-01-30 13:40 UTC by Philip Meyer
Modified: 2008-12-18 11:12 UTC (History)
0 users

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Philip Meyer 2008-01-30 13:40:01 UTC
In the default skin, I tried to change the player menu settings.  I was trying to move the last entry in the list upwards.

[21:33:07.5017] Slim::Networking::Select::select (245) Error: Select task failed: Can't call method "isPlayer" on an undefined value at P:/Music/SlimServer/trunk/server/Slim/Web/Settings/Player/Menu.pm line 39.
Comment 1 Michael Herger 2008-01-30 14:00:07 UTC
Will take a look at this tomorrow. Thanks!
Comment 2 KDF 2008-01-30 14:20:52 UTC
this is a missing playerid param, and applies to all player settings pages in default skin
Comment 3 KDF 2008-01-30 14:25:04 UTC
hmm, given that this keeps coming up and the way that the new default skin works, maybe it's reasonable to just 
cover this one for good by adding one line to the settings/header.html:

[% playerid = playerid || player %]

This way, any time a playerid is missing, it will fall back to the currently selected player.
Comment 4 Michael Herger 2008-01-31 02:42:23 UTC
Additionally some of the links were messed up due to "&" vs. "&", which lead to loss of the playerid. Might explain other issues which recently have been reported in the forums (and I never was able to reproduce).

Please re-open if change 17009 (and a browser refresh ;-)) doesn't fix this for you. Thanks!
Comment 5 Chris Owens 2008-03-07 09:04:38 UTC
This bug is being closed since it was resolved for a version which is now released!  Please download the new version of SqueezeCenter (formerly SlimServer) at http://www.slimdevices.com/su_downloads.html

If you are still seeing this bug, please re-open it and we will consider it for a future release.