Bug 6854 - Album Covers incorrect in Fishbone
: Album Covers incorrect in Fishbone
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Display
: 7.0
: PC Windows XP
: P2 normal (vote)
: ---
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-01-29 11:40 UTC by Steve Sheafor
Modified: 2008-12-18 11:12 UTC (History)
0 users

See Also:
Category: ---


Attachments
Bad track display, large cover (221.43 KB, image/pjpeg)
2008-01-29 11:41 UTC, Steve Sheafor
Details
Bad album display, large cover art (217.41 KB, image/pjpeg)
2008-01-29 11:42 UTC, Steve Sheafor
Details
Bad album display, small cover art (225.58 KB, image/pjpeg)
2008-01-29 11:42 UTC, Steve Sheafor
Details
Bad track display, small cover art (190.13 KB, image/pjpeg)
2008-01-29 11:43 UTC, Steve Sheafor
Details
Bad album display after fix attempt (306.37 KB, image/pjpeg)
2008-01-30 08:25 UTC, Steve Sheafor
Details
Bad track display after 2nd fix attempt (225.94 KB, image/pjpeg)
2008-01-31 07:26 UTC, Steve Sheafor
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Sheafor 2008-01-29 11:40:36 UTC
I just downloaded the latest version of 7.0 - 16880.  Now the display of albums and tracks is corrupted, apparently because the calculation about the size of the album cover and where to put it is wrong.  The attached screen shots show the two types of errors.  Note that the Default skin does not have this problem, and that my previous version (16051) was correct.

The first screen shot (squeeze13) shows the display of the first track in the playlist.  The album cover overwrites much of the display.

The second shot (squeeze14) shows the album display from the first track in the playlist.  Note that only part of the cover is shown, it overwrites the album information, and the option to select/delete all tracks is gone.

The third shot (squeeze15) shows the album display from the second album in the playlist.  Since the cover art is smaller, it doesn't overwrite any information but it is still partially shown and the "all track" option is gone.

The fourth shot (squeeze16) shows the display of a track from the second album.  Again since the cover art is small it only overwrites a small part of the information (the upper left corner selections).
Comment 1 Steve Sheafor 2008-01-29 11:41:43 UTC
Created attachment 2767 [details]
Bad track display, large cover
Comment 2 Steve Sheafor 2008-01-29 11:42:07 UTC
Created attachment 2768 [details]
Bad album display, large cover art
Comment 3 Steve Sheafor 2008-01-29 11:42:27 UTC
Created attachment 2769 [details]
Bad album display, small cover art
Comment 4 Steve Sheafor 2008-01-29 11:43:12 UTC
Created attachment 2770 [details]
Bad track display, small cover art
Comment 5 Steve Sheafor 2008-01-29 12:03:01 UTC
One additional note - SqueezeCenter is running on Windows Home Server in an HP MediaSmart server.  My previous version (16051) was also running in this environment.  The displays are in IE7 on a client machine running XP Pro.
Comment 6 Michael Herger 2008-01-29 12:26:21 UTC
Seeing this in IE6, too. Do you have another browser? Could you confirm it's fine there?
Comment 7 Michael Herger 2008-01-29 12:40:29 UTC
fixed in change 16918 - please force a browser refresh and try again.
Comment 8 KDF 2008-01-29 12:51:40 UTC
classic will need the same fix
Comment 9 Michael Herger 2008-01-29 12:59:45 UTC
How could I forget... change 16919 - thanks!
Comment 10 Steve Sheafor 2008-01-30 08:24:35 UTC
I downloaded the latest version of 7.0 - 16955 (well after the fix).  The track display is now correct, but the album display is still wrong.  See the attached screen shot squeeze17.  There are two problems which are probably related.  The first is the incorrect cover art display, and the second is the lack of the "All tracks" selection.  This may be covered up by the cover art in some way.  

I'm hoping the idea of "All tracks" isn't supposed to be gone, since it is one of the most useful features.  When I want to remove an album from the Playlist after playing it, the simplest way is to select the album and then delete all tracks.  Please don't eliminate this feature.

Michael, I don't have another browser beyond IE7 to test this with.
Comment 11 Steve Sheafor 2008-01-30 08:25:07 UTC
Created attachment 2775 [details]
Bad album display after fix attempt
Comment 12 Steve Sheafor 2008-01-30 08:29:05 UTC
Based on earlier comments, I checked the Classic skin, and the album display is correct there (although "All tracks" is gone).  I didn't look at this before, so I can't verify it was broken before the fix.
Comment 13 KDF 2008-01-30 17:30:08 UTC
change 17003

all tracks links are at the top with the album info.
Comment 14 Steve Sheafor 2008-01-30 18:57:33 UTC
In the version I have now (which still has the cover art display bug) I can see icons to add all tracks to the playlist and to play the album at the top of the album display, but there isn't anything which would delete all tracks from the album from the playlist.  For me this is the important "all tracks" function, which has always existed in Fishbone until I downloaded 16880.  See the last screen shot I attached "Bad album display after fix attempt".

Release 17003 refers to this bug.  If you think that fixes this I will check tomorrow.
Comment 15 Steve Sheafor 2008-01-31 07:25:56 UTC
I downloaded the latest version of 7.0 - 17006.  Now the album display is correct (and does have the All Tracks controls - thanks), but the track display is corrupted.  The cover art is now always the correct size, but it is positioned at the very top of the pane and hides the track title.  See the latest attachment squeeze18.
Comment 16 Steve Sheafor 2008-01-31 07:26:32 UTC
Created attachment 2782 [details]
Bad track display after 2nd fix attempt
Comment 17 Steve Sheafor 2008-01-31 07:30:41 UTC
Note - Classic and Default skins are both OK.
Comment 18 Michael Herger 2008-01-31 07:54:01 UTC
change 17029 - here you go again! Thanks!
Comment 19 KDF 2008-01-31 08:29:34 UTC
and change 17031
Comment 20 KDF 2008-01-31 12:02:32 UTC
ok, there are still bits that are coming out wrong! comments are shifting in FF, and IE with classic skin seems to disappear sometimes.  Also, EN songinfo.html should be the one we're using for default as there is no point having EN be the only case for that version of the template. Fishbone and classic both use the same version as we use in Default.  I've got some fixes which I will test and commit soon.
Comment 21 KDF 2008-01-31 12:38:46 UTC
ok change 17044 should have it (at least everything I was looking for). reopen if there is anything still not right.
Comment 22 Steve Sheafor 2008-02-05 10:02:45 UTC
I installed version 17225 - everything looks fine.
Comment 23 Chris Owens 2008-03-07 09:04:37 UTC
This bug is being closed since it was resolved for a version which is now released!  Please download the new version of SqueezeCenter (formerly SlimServer) at http://www.slimdevices.com/su_downloads.html

If you are still seeing this bug, please re-open it and we will consider it for a future release.