Bug 6841 - Local vs. remote cover art is sized differently in Now Playing
: Local vs. remote cover art is sized differently in Now Playing
Status: CLOSED FIXED
Product: SB Controller
Classification: Unclassified
Component: UI
: unspecified
: Macintosh Other
: P2 normal (vote)
: 7.0
Assigned To: Ben Klaas
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-01-28 15:57 UTC by Andy Grundman
Modified: 2009-09-08 09:24 UTC (History)
0 users

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Grundman 2008-01-28 15:57:26 UTC
 
Comment 1 Ben Klaas 2008-01-28 20:54:30 UTC
hmmm...the problem is that for local artwork we can give a _p flag for padding the image with transparency, which is what allows it to fit in the specified area. but when we retrieve image remotely, there isn't a means for doing that.

remote image:
{ --[[table: 0x1601b140]]
  { --[[table: 0x160464a0]]
    thumb = false,
    url = "http://images-lev3-1.pandora.com/images/public/amz/2/2/5/0/801655110522_130W_130H.jpg",
    key = "http://images-lev3-1.pandora.com/images/public/amz/2/2/5/0/801655110522_130W_130H.jpg",
    size = 154,
  },
}

local image:
{ --[[table: 0x1603db70]]
  { --[[table: 0x167730a0]]
    thumb = true,
    url = "/music/1424/cover_154x154_p.png",
    key = 1424,
    size = 154,
  },
}

In the skin I'm going to see if I can make the progress bar group, which is the only thing below the artwork, not depend on the placement of the artwork. If that fails, I'm unsure of a solution.

Comment 2 Blackketter Dean 2008-01-29 22:19:02 UTC
I"m a little confused.  Is the source artwork size different or is it rendered differently?
Comment 3 Ben Klaas 2008-01-30 07:42:13 UTC
This only happens with remote, non-square artwork. The issue is that these images don't get transparent padding, and the progress bar's placement is dependent on where the bottom of the artwork is.
Comment 4 Ben Klaas 2008-01-31 12:36:56 UTC
fixed r1729

Description: layout all progress bar elements from bottom of the screen (LAYOUT_SOUTH)
this allows remote, non-padded, non-square images to not affect the layout of the page
Comment 5 James Richardson 2008-05-15 13:02:39 UTC
This bug has recently been fixed in the latest release of SqueezeCenter 7.0.1

Please try that version, if you still see the error, then reopen this bug.

To download this version, please navigate to: http://www.slimdevices.com/su_downloads.html