Bug 6825 - Default skin - Artists > All Songs needs album name
: Default skin - Artists > All Songs needs album name
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Skins
: 7.0
: PC Windows XP
: P2 normal (vote)
: ---
Assigned To: Michael Herger
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-01-28 08:18 UTC by Jim McAtee
Modified: 2008-12-18 11:12 UTC (History)
0 users

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jim McAtee 2008-01-28 08:18:54 UTC
Browsing into Artists > Arsist Name > All Songs fails to list the album.
Comment 1 Michael Herger 2008-01-28 10:13:12 UTC
Does this work for you (and not break the other browse modes)?

Index: D:/workspace/trunk/server/HTML/Default/browsedb.html
===================================================================
--- D:/workspace/trunk/server/HTML/Default/browsedb.html	(revision 16819)
+++ D:/workspace/trunk/server/HTML/Default/browsedb.html	(working copy)
@@ -87,7 +87,7 @@
 		[% END -%]
 
 		[% FOREACH item = browse_items -%]
-			[%- PROCESS browsedbitems_list.html item.includeAlbum = 0 item.includeArtist = album.compilation -%]
+			[%- PROCESS browsedbitems_list.html item.includeAlbum = !album.id.defined item.includeArtist = album.compilation -%]
 		[%- END %]
 	[% END -%]
 
Comment 2 Blackketter Dean 2008-01-28 10:16:36 UTC
 I don't understand.  Do you want the album name visible or another kind of organization?
Comment 3 Michael Herger 2008-01-28 12:10:57 UTC
If you browse Artist -> All Songs other skins display the album name together with the song. Default does not. My patch should fix this, but it was a last minute change I did before leaving. Thus would like to give it more testing before checking in.
Comment 4 Michael Herger 2008-01-29 00:37:24 UTC
change 16881
Comment 5 Chris Owens 2008-03-07 09:04:37 UTC
This bug is being closed since it was resolved for a version which is now released!  Please download the new version of SqueezeCenter (formerly SlimServer) at http://www.slimdevices.com/su_downloads.html

If you are still seeing this bug, please re-open it and we will consider it for a future release.