Bug 6797 - Command-line debug switches should not persist
: Command-line debug switches should not persist
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Misc
: 7.0
: Macintosh Other
: P2 normal (vote)
: ---
Assigned To: Andy Grundman
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-01-26 11:51 UTC by Andy Grundman
Modified: 2008-12-18 11:12 UTC (History)
2 users (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Grundman 2008-01-26 11:51:00 UTC
 
Comment 1 KDF 2008-01-26 12:22:43 UTC
when did this start?  that's what the --persist option was for.
Comment 2 Andy Grundman 2008-01-26 12:44:24 UTC
It's been annoying me for a while.  They don't persist every time, but sometimes they do.  I never use the --persist option (which isn't even listed in --help by the way).
Comment 3 Adrian Smith 2008-01-26 13:26:52 UTC
'persist' can be used as one of the elements in the comma separated logging list:

--logging favorites=WARN,persist

I think the saving of command line options occurs if you do something which causes the config file to be written - at present it will save the running config including command line options...
Comment 4 Blackketter Dean 2008-01-26 21:37:58 UTC
Let's punt on this post-7.0.  Who would be working on this?
Comment 5 Andy Grundman 2008-01-29 09:47:13 UTC
This is constantly driving me nuts, I think I am going to fix it right now.
Comment 6 KDF 2008-01-29 15:46:58 UTC
scan calls a writeConfig (Slim::Music::Import::launchScan, line 96).  This, of course, makes sense in the case of passing the existing state on to the scanner process.  It would, however, result in a persistence case.  If we make this the same logic as that in Slim::Utils::Log::reInit(), then any debug that is desired in the scanner would require persist option selected.
Comment 7 Andy Grundman 2008-01-29 15:51:55 UTC
Aha, that must be it.  There's probably an easy solution, I'll think about it.
Comment 8 Andy Grundman 2008-01-29 16:31:37 UTC
Fixed in change 16937.  Just pass the debug command-line options to the scanner, no need to save the log file.
Comment 9 Chris Owens 2008-03-07 09:03:30 UTC
This bug is being closed since it was resolved for a version which is now released!  Please download the new version of SqueezeCenter (formerly SlimServer) at http://www.slimdevices.com/su_downloads.html

If you are still seeing this bug, please re-open it and we will consider it for a future release.