Bug 6792 - Flac transcode update to convert.conf
: Flac transcode update to convert.conf
Status: RESOLVED WONTFIX
Product: Logitech Media Server
Classification: Unclassified
Component: Audio
: 7.0
: PC Windows XP
: -- enhancement (vote)
: 7.x
Assigned To: Andy Grundman
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-01-26 01:03 UTC by sbjaerum
Modified: 2009-09-08 09:11 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sbjaerum 2008-01-26 01:03:15 UTC
With Flac 1.2.1 (included in SC 7.0), it is possible to do flac to flac transcoding without piping between to separate flac processes. I have used the following change in convert.conf for months without any problems (on WinXP).

Index: server/convert.conf
===================================================================
--- server/convert.conf (revision 16718)
+++ server/convert.conf (working copy)
@@ -155,7 +155,7 @@
        [lame] --resample 44100 --silent -q $QUALITY$ --abr $BITRATE$ $FILE$ -

 flc flc transcode *
-       [flac] -dcs --skip=$START$ --until=$END$ -- $FILE$ | [flac] -cs --totally-silent --compression-level-0 -
+       [flac] -c --totally-silent --compression-level-0 --skip=$START$ --until=$END$ $FILE$ -
Comment 1 James Richardson 2008-03-24 10:52:01 UTC
Reassigning to Andy.  Is this something that we have already implemented?  We are now shipping 1.2.1 so this should be easy to add.
Comment 2 Andy Grundman 2008-03-24 10:59:09 UTC
What's the use case for flac -> flac anyway?
Comment 3 sbjaerum 2008-03-24 11:47:35 UTC
Use case: Entire album encoded to flac + cuesheet. Quite a lot of users for this I think.
I have used the patch for months, so it is definitely a safe change.
Comment 4 Andy Grundman 2008-03-24 11:52:07 UTC
Ah right, OK, I'll apply.
Comment 5 Jim McAtee 2008-03-24 14:18:28 UTC
You need to be aware that this method fails when there's an id3v2 tag in the file, while the current method will still work.  Yes, Flac files should not have id3v2 tags, but they're surprisingly common in the wild, perhaps because it's easy to configure EAC to add id3v2 any time it calls an external encoder.

See the response from Josh Coalson at URL below about why flac bails out when called this way if it encounters an id3v2 tag.

http://www.hydrogenaudio.org/forums/index.php?showtopic=50993&st=75&p=464359&#entry464359

Comment 6 Andy Grundman 2008-03-24 14:23:24 UTC
Thanks, so I guess we won't be doing this.
Comment 7 Andy Grundman 2008-03-28 11:06:02 UTC
Based on JJ's comment I am going to mark this as won't fix.
Comment 8 Chris Owens 2009-07-31 10:16:27 UTC
Reduce number of active targets for SC