Bug 6769 - Artwork cacheing fails for audio-file embedded images + inefficient checks
: Artwork cacheing fails for audio-file embedded images + inefficient checks
Status: CLOSED FIXED
Product: Logitech Media Server
Classification: Unclassified
Component: Database
: 7.0
: PC Other
: P2 normal (vote)
: ---
Assigned To: Andy Grundman
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-01-25 00:23 UTC by Alan Young
Modified: 2009-09-08 09:30 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
Patch (3.19 KB, patch)
2008-01-25 00:25 UTC, Alan Young
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Young 2008-01-25 00:23:19 UTC
The artwork cacheing mechanism caches an image object that the retrieval code considers to be an unusable entry. In this case, it needs to note the audio file from which the image was derived and which can be used for mtime checks.

Additionaly, Slim::Schema:Track::coverArt is often used as a boolean. This is inefficient as it results in reading and examining the image, from image file or tag in an audio file. Better to use coverArtExists, which needs to be enhanced to know if knowledge of cover-art existance has been cached.

The attached patch deals with these issues.
Comment 1 Alan Young 2008-01-25 00:25:39 UTC
Created attachment 2724 [details]
Patch
Comment 2 Blackketter Dean 2008-01-25 17:40:02 UTC
Andy: does this patch look good to you?
Comment 3 Andy Grundman 2008-01-25 17:43:15 UTC
I'm sure it's fine but I will test it tomorrow.
Comment 4 Andy Grundman 2008-01-27 06:03:25 UTC
Patch applied in change 16798.
Comment 5 Chris Owens 2008-03-07 09:03:29 UTC
This bug is being closed since it was resolved for a version which is now released!  Please download the new version of SqueezeCenter (formerly SlimServer) at http://www.slimdevices.com/su_downloads.html

If you are still seeing this bug, please re-open it and we will consider it for a future release.