Bug 6765 - songinfo results lose last lines
: songinfo results lose last lines
Status: CLOSED FIXED
Product: SB Controller
Classification: Unclassified
Component: Browser
: unspecified
: PC Windows XP
: P2 normal (vote)
: 7.0
Assigned To: Ben Klaas
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-01-24 17:03 UTC by KDF
Modified: 2009-09-08 09:21 UTC (History)
1 user (show)

See Also:
Category: ---


Attachments
patch (1.25 KB, patch)
2008-01-24 17:06 UTC, KDF
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description KDF 2008-01-24 17:03:46 UTC
The counts are off for the song info results because it counts the keys, then only adds 1 for $insertPlay.  Since we're now adding PLAY, ADD, and ADD_FAVORITES, this leaves the last two items off the song info display.

Jive console shows:
160558:15603 DEBUG (...\slim\src\pkg\release\lua\applets\SlimBrowser\DB.lua:121) - ..store invalid, different count

I propose that the better solution is to increment count at each add.  We're already doing the decrement for each suppressed key, so it should be easier to keep track if it's incremented at the same point as the new lines are added.

patch shortly.
Comment 1 KDF 2008-01-24 17:06:07 UTC
Created attachment 2723 [details]
patch

this patch moves the count changes to where the actual changes are being made, and also allows the full songinfo result to show. It's low risk, so I'd like to know if it is cleared for 7.0 or not.
Comment 2 Blackketter Dean 2008-01-25 17:20:30 UTC
Ben: Can you review this patch?
Comment 3 KDF 2008-01-25 19:01:19 UTC
Ben already put the patch in at change 16746.  Further changes went in as part of change 16765.

This is now fixed.
Comment 4 James Richardson 2008-05-15 13:02:07 UTC
This bug has recently been fixed in the latest release of SqueezeCenter 7.0.1

Please try that version, if you still see the error, then reopen this bug.

To download this version, please navigate to: http://www.slimdevices.com/su_downloads.html