Bug 6758 – Music Library->New Music throws exception on Jive

Bug 6758 - Music Library->New Music throws exception on Jive

Summary:

Music Library->New Music throws exception on Jive

Status:	CLOSED WORKSFORME

Product:	SB Controller
Classification:	Unclassified
Component:	Browser
Version:	unspecified
Platform:	Macintosh Other

Importance:	-- normal (vote)
Target Milestone:	7.0.1
Assigned To:	Ben Klaas

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2008-01-24 08:13 UTC by Ben Klaas
Modified:	2008-05-15 12:27 UTC (History)
CC List:	0 users

See Also:
Category:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Ben Klaas 2008-01-24 08:13:30 UTC

This is an SC problem in the request response in Slim::Control::Queries::albumsQuery. I already have a fix-- can it go in 7.0?


100945:1379816 ERROR (RequestHttp.lua:67) - Response sink:...0/jive/src/pkg/jive/share/applets/SlimBrowser/DB.lua:171: chunk must have item_loop field if count>0
stack traceback:
        .../7.0/jive/src/pkg/jive/share/jive/utils/coxpcall.lua:28: in function <.../7.0/jive/src/pkg/jive/share/jive/utils/coxpcall.lua:26>
        (tail call): ?
        (tail call): ?
        (tail call): ?
        ...7.0/jive/src/pkg/jive/share/jive/net/RequestHttp.lua:64: in function 'snk'
        .../branches/7.0/jive/build/osx/share/lua/5.1/ltn12.lua:262: in function 'mySink'
        ....0/jive/src/pkg/jive/share/jive/net/CometRequest.lua:135: in function 't_setResponseBody'
        .../7.0/jive/src/pkg/jive/share/jive/net/SocketHttp.lua:652: in function 'snk'
        .../branches/7.0/jive/build/osx/share/lua/5.1/ltn12.lua:277: in function 'step'
        .../7.0/jive/src/pkg/jive/share/jive/net/SocketHttp.lua:717: in function 'pump'
        ...s/7.0/jive/src/pkg/jive/share/jive/net/SocketTcp.lua:202: in function 'readPump'
        ...ches/7.0/jive/src/pkg/jive/share/jive/net/Socket.lua:143: in function <...ches/7.0/jive/src/pkg/jive/share/jive/net/Socket.lua:141

Comment 1 Ben Klaas 2008-01-24 12:06:29 UTC

I was wrong, my fix is not good enough.

This bug throws an exception to the jive console but otherwise causes no issue (the New Music window is fully usable)

The issue is that this line

# now build the result
my ($valid, $start, $end) = $request->normalize(scalar($index), scalar($quantity), $count);

returns 0 for $valid in the last part of the 'new music' query.

as a result, the request returns a count and no item_loop, which throws an exception.

IMO this can wait until 7.0.1. It'll be invisible to a user.

Comment 2 Richard Titmuss 2008-03-12 04:53:33 UTC

Reset priority

Comment 3 Ben Klaas 2008-03-19 08:30:52 UTC

removing priorities from all 7.0.1 target bugs for re-prioritizing

Comment 4 Ben Klaas 2008-03-21 14:53:46 UTC

I belive this was fixed as the result of some other fixes with chunked repsonses. I no longer see it.

Comment 5 James Richardson 2008-05-15 12:27:23 UTC

This bug has recently been fixed in the latest release of SqueezeCenter 7.0.1

Please try that version, if you still see the error, then reopen this bug.

To download this version, please navigate to: http://www.slimdevices.com/su_downloads.html